Skip to content

Fix Wconversion warning in catch_reporter_helpers.cpp#3094

Open
PB-Ole wants to merge 1 commit intocatchorg:develfrom
PB-Ole:catch-mingw-wconversion-build
Open

Fix Wconversion warning in catch_reporter_helpers.cpp#3094
PB-Ole wants to merge 1 commit intocatchorg:develfrom
PB-Ole:catch-mingw-wconversion-build

Conversation

@PB-Ole
Copy link
Copy Markdown

@PB-Ole PB-Ole commented May 5, 2026

Description

When compiling Catch2 with mingw and -Wconversion flag enabled the catch_reporter_helpers.cpp file fails to build since maxTagCountLen is of type size_t and used as input for std::setw which expects an int as input.

This simply fixes the type of maxTagCountLen which is used nowhere else except for setting the stream width.

GitHub Issues

I did not find an issue mentioning this. If needed, I can create one.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.33%. Comparing base (11a96e1) to head (83d4156).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3094      +/-   ##
==========================================
- Coverage   91.36%   91.33%   -0.03%     
==========================================
  Files         204      204              
  Lines        8903     8903              
==========================================
- Hits         8134     8131       -3     
- Misses        769      772       +3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant