Open
Conversation
jvega
commented
May 28, 2024
Comment on lines
+256
to
261
| $parsedValue = match ($attr['name']) { | ||
| 'width', 'height' => str_contains($attr['value'], '%') ? $attr['value'] : intval($attr['value']), | ||
| default => htmlspecialchars_decode($attr['value'], ENT_COMPAT), | ||
| }; | ||
| ${$attr['name']} = $parsedValue; | ||
| } |
Author
There was a problem hiding this comment.
also I fix an issue when an IMG tag has defined the attribute width lower than image width
jvega
commented
May 28, 2024
| ->setActualCacheDir($cacheDir); | ||
| $image->zoomCrop($width, $height); | ||
| return str_replace($cacheDir, 'images', $image->cacheFile($format, $quality)); | ||
| return str_replace($cacheDir, '/images', $image->cacheFile($format, $quality)); |
Author
There was a problem hiding this comment.
and this fix when the site has nested pages
jvega
commented
May 29, 2024
|
|
||
|
|
||
| private function generatePictureMarkup($file, string $alt = '', ?float $ratio = null, ?array $breakpoints = null, ?int $maxWidth = null, ?string $loading = null, ?string $class = null, ?string $title = null, ?array $densitySet = null): string | ||
| private function generatePictureMarkup($file, string $alt = '', ?float $ratio = null, ?array $breakpoints = null, ?int $maxWidth = null, ?string $loading = null, ?string $class = null, ?string $title = null, ?array $densitySet = null, ?string $style = null): string |
jvega
commented
May 29, 2024
Comment on lines
+171
to
+173
| if (str_contains($file, '?')){ | ||
| [$file] = explode('?', $file); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I added background support.
Should be implemented with custom template
bg_picture.html.twig