Skip to content

Clean up settings page - #765

Merged
petersistrom merged 3 commits into
MOODLE_404_STABLEfrom
settings-updates
Aug 26, 2026
Merged

Clean up settings page#765
petersistrom merged 3 commits into
MOODLE_404_STABLEfrom
settings-updates

Conversation

@bwalkerl

@bwalkerl bwalkerl commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
  • Re-add s3 credential provider chain check that was removed by mistake in Implemented new check class for cloud storage connection and added to settings page. #729 - checks whether the it is safe to enable the use credential provider chain setting. This has been converted to use the check API and only provides information relevant to the use of a single setting so is only required on settings page when not checked. The results of this check have been also updated to INFO and lang strings made more descriptive.
  • Move connection status to the above where the client settings are set, so status is visible when updating client settings.
  • Cherry-pick Issue #633: Move preferexternal setting #641

Comment thread classes/check/s3_sdkcreds.php
Comment thread lang/en/tool_objectfs.php
Comment thread settings.php
@petersistrom

petersistrom commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Code looks good, just a couple of comments above

@petersistrom
petersistrom merged commit e1b4d13 into MOODLE_404_STABLE Aug 26, 2026
31 checks passed
@petersistrom
petersistrom deleted the settings-updates branch August 26, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants