Add settings for multi-highlight - #5
Open
gbarat87 wants to merge 3 commits into
Open
Conversation
Update settings to handle multi highlight
gbarat87
force-pushed
the
setting-bis
branch
from
September 3, 2026 05:37
e80cbde to
e4418c3
Compare
|
Hi @gbarat87, Thank you for working on this. I am still looking through the code but here is some initial feedback. The live preview only updates on label change, it should also update when the colour is changed. The enabled checkbox should be removed from the instance settings (keep it configurable from the Element order should be:
Please use modern ES modules for all javascript and avoid using jQuery. The preview could be a mustache template with {{#js}} tags to load the module automatically when rendered. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this close #3

Add Highlight + list of existing one
Settings for edit/new highlight with preview
