Skip to content

Add settings for multi-highlight - #5

Open
gbarat87 wants to merge 3 commits into
mainfrom
setting-bis
Open

Add settings for multi-highlight#5
gbarat87 wants to merge 3 commits into
mainfrom
setting-bis

Conversation

@gbarat87

@gbarat87 gbarat87 commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

this close #3
Add Highlight + list of existing one
image

Settings for edit/new highlight with preview
image

@Fragonite

Copy link
Copy Markdown

Hi @gbarat87,

Thank you for working on this. I am still looking through the code but here is some initial feedback.

The live preview only updates on label change, it should also update when the colour is changed.

The enabled checkbox should be removed from the instance settings (keep it configurable from the filtersettingexternalcontent section).

Element order should be:

  • Name
  • Domains
  • Label
  • Text colour
  • Background colour
  • Preview
  • Save changes/Cancel

Please use modern ES modules for all javascript and avoid using jQuery. The preview could be a mustache template with {{#js}} tags to load the module automatically when rendered.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin config

2 participants