fix: replace malformed bundle @id with UUID4 - #156
Open
forest-savage1234 wants to merge 1 commit into
Open
Conversation
Closes casework#88. The live network_connection.json bundle @id still had a 9-hex first group (kb:bundle-2a13e958a-...). Replaced in place with a UUID4. No @graph reshape. Oresteia untouched. Out of scope: wrapping the Bundle in @graph (Alex 2022-08-11), Oresteia.json, converting already-valid UUID @ids, indentation / pre-commit policy. Identity if committed: Forest Savage <forestsavage03@gmail.com> Do not push from this packet.
Author
|
Thank you for the time on this review. This only replaces a malformed bundle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix malformed bundle @id UUID in network_connection.json
Closes #88.
Repo rules (casework/CASE-Examples): no CONTRIBUTING, no PR template, no DCO. Open against
master.makeinstalls pre-commit; indentation is pre-commit’s job (Alex 2022-08-10). No invented checklist.In: one
@idinexamples/illustrations/network_connection/network_connection.json.Out:
@graphreshape (Alex 2022-08-11); Oresteia.json; already-valid UUID@ids; converting the two UUID5s that already match a UUID pattern.Review: search
2a13e958a— it should be gone.Summary
Alex narrowed #88 to in-place UUID4
@ids. Do not reshape@graph. The live illustration still had one IRI that does not end in a UUID:kb:bundle-2a13e958a-d975-41aa-b1bb-029d2b6707ab(first group is 9 hex digits). It becomes
kb:bundle-017c3954-b5a5-4114-a4a1-e6e403b3c96a. That@idis not referenced elsewhere in the file.Validation
Shallow clone of casework/CASE-Examples
master@8e0512709d984966cc2fc77603281bd1ab8251d9(2026-07-22 7:11am AKDT) in/workspace/checkouts/CASE-Examples.PATCH.diffapplied (patch -p1). One file, one@id. No@graph. Identity for any later commit: Forest Savage forestsavage03@gmail.com. Nothing posted.Exit 0.
make checkon this clone after the patch (submodules initialized by the repo Makefile; logged run after deps existed):examples/illustrations/network_connectionentered,case_validateran onnetwork_connection.json(default + develop + develop-2.0.0 + unstable + unstable-2.0.0), then left that directory. NoERROR/FAILEDlines in the log.make checkexit 0. Working tree still only the one@idline (validation TTL files were regenerated in place and matched). Oresteia generated files stayed up to date.Files
examples/illustrations/network_connection/network_connection.json(one@id)Out of scope
@graph(Alex: out of scope; named-graph/quads)@ids (including two UUID5s that already match the UUID pattern)How to review
One IRI. Search the old
2a13e958atoken; it should be gone.Volunteer stand-down
I am a volunteer. If the extra
2is intentional, I will stand down.I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes.
If the UUID4 should stay the old string, say so and I will stand down.