Don't create extensions inside a transaction#349
Merged
Conversation
Extensions created inside a transaction don't make their objects (functions, types, etc.) available to subsequent statements in that transaction, which causes `db push` to fail when tables reference extension-provided defaults like `uuid_generate_v4()`. Move schema and extension creation before the transaction so their objects are available when tables are created. Closes #332 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CREATE SCHEMAandCREATE EXTENSIONstatements outside the transaction indb pushuuid_generate_v4()IF NOT EXISTSso they're safe to run outside a transactionCloses #332
Test plan
db pushwith a config that uses extensions (e.g.uuid-ossp) and verify tables with extension-provided defaults are created successfully🤖 Generated with Claude Code