Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the development environment by pinning dependency versions to avoid major version issues, updating dependency sources to reference GitHub, and configuring MyPy settings.
- Update dependency versions and constraints in setup.py
- Add MyPy configuration in pyproject.toml
- Update flake8 repository URL in .pre-commit-config.yaml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Pin versions for multiple dependencies to enforce v4 for moto and consistent versioning for others |
| pyproject.toml | Add MyPy configuration settings for namespace_packages and explicit_package_bases |
| .pre-commit-config.yaml | Change flake8 repository from GitLab to GitHub |
|
I ran into an unexpected issue while reviewing this PR. Please try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
motois used in tests for S3 and v5 has a breaking change compared to v4. Other dev dependencies are also not pinned.testing.postgreshasn't been updated since 2015 and fails.blackhook was failing due to re-formatting of tests.flipper-clientis not a valid Python package name.redisandcachetools.Solutions
blackand formatted tests.flipper-clientand don't change the existing package name.