Grid ladder cleanup: reject even level counts, tighten enums#1017
Merged
Conversation
- Reject even level_count at the model layer: an even count produces an asymmetric grid (e.g. 2 buys / 1 sell for level_count=4), which breaks the mean-reversion assumption. - Tighten GridLadderTable.exchange and market_type to NOT NULL (matching the GridLadderRecord shape), with a follow-up migration that backfills any NULL rows before adding the constraint. - Correct CRUD type hints for create(): `ExchangeId | str` and `MarketType | str` (the route already passes enums). - calculate_grid_levels now returns a CalculatedGrid carrying both the levels and the grid_step, so the route no longer has to recompute grid_step separately. - Tests: cover even-level rejection, SPOT and non-KuCoin rejection; refit existing tests to the new CalculatedGrid return shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
carkod
force-pushed
the
grid-ladder-cleanup
branch
from
44974b7 to
4d1fe64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExchangeId | strandMarketType | str(the route already passes enums).