This repository was archived by the owner on Aug 1, 2026. It is now read-only.
Potential fix for code scanning alert no. 2: Second order command injection - #28
Draft
daddia wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 2: Second order command injection#28daddia wants to merge 1 commit into
daddia wants to merge 1 commit into
Conversation
…ection Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/carinyaparc/carinyaparc/security/code-scanning/2
To fix this safely without changing functionality, ensure user-influenced ref arguments are always passed after Git’s end-of-options marker
--for commands that accept refs (fetch,checkout). This prevents Git from interpreting attacker-controlled strings as flags even if validation is bypassed or changed later.Best single fix in this snippet:
packages/crew/src/workspace.ts, update:['fetch', 'origin', branch]→['fetch', 'origin', '--', branch]['checkout', '-b', branch, \origin/${branch}`]→['checkout', '-b', branch, '--', `origin/${branch}`]`['checkout', '-b', branch]→['checkout', '-b', branch, '--']This is defense-in-depth and keeps existing branch validation logic intact.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.