Conversation
The POST /_screenshot-card surface can answer a --spec file's
captureSpec: { type: 'pdf' } with contentType: application/pdf, and the
extension map's png fallback landed those bytes in a .png file. Map the
content type to a .pdf extension and pin it with a test.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
boxel screenshotcommand passes a--specfile'scaptureSpecthrough to POST/_screenshot-cardverbatim, so a spec requestingcaptureSpec: { type: "pdf" }gets backcontentType: application/pdf— butEXTENSION_BY_CONTENT_TYPEmapped only the three image types and fell back topng, landing the paged document in a.pngfile. Mapapplication/pdfto a.pdfextension.Testing
tests/commands/screenshot.test.ts: a pdf capture response writes its bytes to a.pdffile — green locally along with the rest of the screenshot command suite.🤖 Generated with Claude Code