Cover PDF captures in the screenshot-perf-diagnosis skill - #6141
Draft
lukemelia wants to merge 2 commits into
Conversation
lukemelia
changed the base branch from
cs-12977-persist-pdfs-to-mediacache-and-serve-from-the-get
to
cs-12978-implement-mediaprint-emulation-and-css-driven-paper-size
September 15, 2026 23:09
lukemelia
added this pull request to stack #6122
September 15, 2026 23:09
The screenshot-perf events now carry a contentType dimension (image/* for raster, application/pdf for paged output) on both the request and capture event types, and the dashboard grows a matching contentType template variable. Teach the skill to use it: - Document contentType on both event envelopes: request events derive it from the spec or the served ledger row, capture events report what the render produced. - Add a "PDF captures" section — a type=pdf capture runs the same hit-vs-render / stage-breakdown runbook scoped to application/pdf, with pagination cost landing in the render's capture stage and an over-bounds document (past the 20-page / 10 MB caps) surfacing as a status=error capture / outcome=error request rather than a slow success. - Thread the encoding dimension through the frontmatter description, the dashboard template vars, and the ledger SQL (content_type column). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014GsYGsuCqHJz9GAti4jheG
lukemelia
force-pushed
the
cs-12981-update-skills-to-teach-the-pdf-export-capability
branch
from
September 15, 2026 23:25
bafa03e to
df8d4a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #6120 / the PDF persist-and-serve work — base is the
cs-12977branch, notmain.The repo-side half of teaching PDF export: the
.claudescreenshot-perf-diagnosisskill now covers PDF captures. (The user-facing boxel-skills half — theintegrate-screenshot-card-formatpattern, glossary, and integration-surfaces — lives in the separatecardstack/boxel-skillsrepo: cardstack/boxel-skills#138.)What changed
boxel:screenshot-perfevents carry acontentTypedimension (image/*for raster,application/pdffor paged output) on both event types, and the dashboard has a matchingcontentTypetemplate variable. The skill now:contentTypeon both event envelopes —requestevents derive it from the spec or served ledger row;captureevents report what the render produced (null if it never finished).type=pdfcapture runs the same hit-vs-render / stage-breakdown runbook scoped toapplication/pdf, with pagination cost landing in the render's capture stage, and an over-bounds document (past the 20-page / 10 MB caps) surfacing as astatus=errorcapture /outcome=errorrequest rather than a slow success.content_typecolumn).Docs only — no code paths touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_014GsYGsuCqHJz9GAti4jheG