Repository navigation
Align the card title, cardInfo and FieldDef rules with packages/base - #187
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Staging Workspace Sync SuccessfulSuccessfully synced changes to staging workspace Sync Details |
richardhjtan
approved these changes
Oct 8, 2026
jurgenwerk
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background and Goal
The boxel skills' guidance on card titles didn't match
packages/base, and agents copied the mismatch into the cards they generate. Overrides used??on untrimmed strings, so an empty or whitespace-only value rendered a blank title or atom instead of the fallback. Templates wrappedcardTitlein conditions. FieldDef examples had nodisplayName, so their default atom read "Untitled Field". This brings the rules, references and pattern examples in line with the code, and adds checklist and review-procedure checks for them.Linear: CS-13653
Where to start
skills/boxel/references/core-patterns.md: the card-title rules in one place. The basecardTitlereadscardInfo.namewith anUntitled <displayName>fallback; an override readscardInfo.namefirst, then a primary field, then a fallback; templates render<@fields.cardTitle />unconditionally;cardDescriptionandcardThumbnailURLshow where the card has a summary or image.skills/boxel-patterns/patterns/cardinfo-override-title/: the pattern every new card is pointed at, with trimmed values and thethis.constructor.displayNamefallback.skills/boxel-ui-guidelines/references/checklist.mdandui-review-procedure.md: the checks that catch these in a template.Key decisions and non-obvious mechanics
cardInfo.namefirst is the recommended override, not a requirement. An override replaces the base computation, so skipping it leaves the card-info panel's Name input with no effect; the skills state that cost where they offer the choice.cardInfo.name. A domain field (a headline, a job title) is fine, including as the field an override reads.||. The default atom trimscardTitleand only falls back when it isn't a string, so an override that returns''or whitespace renders an empty atom.cardTitleorcardInfo. Every FieldDef example declares astatic displayName, which the default atom uses; none declarecardTitle.FittedCardis the default for a fitted view of standard pieces. A format's outermost element may fill the host wrapper (width: 100%; height: 100%in fitted) but takes noborder-radius,borderorbox-shadow.🤖 Generated with Claude Code