Skip to content

Check to allow programmatic CDS query.#298

Open
PujaDeshmukh17 wants to merge 1 commit into
developfrom
RBSDMS-UpdateBugFix-feature
Open

Check to allow programmatic CDS query.#298
PujaDeshmukh17 wants to merge 1 commit into
developfrom
RBSDMS-UpdateBugFix-feature

Conversation

@PujaDeshmukh17

Copy link
Copy Markdown
Contributor

Describe your changes

Currently when uploading attachment content via a programmatic CDS query the app crashed because nonDraftAttachmentCreateHandler unconditionally read req.req.url to extract the attachment ID. Programmatic CDS queries have no underlying HTTP request, so req.req is undefined.

With this PR we will be fixing this issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant