Skip to content

Support Multiple Attachments composition in CAP Entity#281

Merged
deepikaSingh2711 merged 19 commits into
developfrom
SDMEXT-Composition-feature
Jun 29, 2026
Merged

Support Multiple Attachments composition in CAP Entity#281
deepikaSingh2711 merged 19 commits into
developfrom
SDMEXT-Composition-feature

Conversation

@deepikaSingh2711

@deepikaSingh2711 deepikaSingh2711 commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your changes

Support Multiple Attachments composition in CAP Entity

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have tested the functionality on my cloud environment.
  • I have provided sufficient automated/ unit tests for the code.
  • I have increased or maintained the test coverage.
  • I have ran integration tests on my cloud environment.
  • I have validated blackduck portal for any vulnerability after my commit.

Upload Screenshots/lists of the scenarios tested

  • I have Uploaded Screenshots or added lists of the scenarios tested in description
Screenshot 2026-06-29 at 10 11 29 AM Screenshot 2026-06-29 at 10 39 18 AM

github-code-quality[bot]
github-code-quality Bot found potential problems Jun 25, 2026
View reviewed changes
Comment thread test/integration/attachments-sdm-multifacet.test.js Fixed
Comment thread test/integration/attachments-sdm-multifacet.test.js Fixed
Comment thread test/integration/attachments-sdm-multifacet.test.js Fixed
deepikaSingh2711 and others added 2 commits June 26, 2026 07:24
@deepikaSingh2711 @github-code-quality
Potential fix for pull request finding 'Useless assignment to local v…
29a82f7 
…ariable'

Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@deepikaSingh2711 @github-code-quality
Potential fix for pull request finding 'Semicolon insertion'
cd9d6b3 
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
PujaDeshmukh17
PujaDeshmukh17 previously approved these changes Jun 29, 2026
View reviewed changes

@PujaDeshmukh17 PujaDeshmukh17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepikaSingh2711
Revert "Update package.json"
980f208 
This reverts commit 8cf9062, reversing
changes made to b734460.
@deepikaSingh2711
Reapply "Update package.json"
8486939 
This reverts commit 980f208.
@deepikaSingh2711
Revert "Reapply "Update package.json""
02fb40b 
This reverts commit 8486939.
rashmiangadi05
rashmiangadi05 approved these changes Jun 29, 2026
View reviewed changes

@rashmiangadi05 rashmiangadi05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepikaSingh2711 deepikaSingh2711 merged commit 20baec8 into develop Jun 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rashmiangadi05 rashmiangadi05 rashmiangadi05 approved these changes
@PujaDeshmukh17 PujaDeshmukh17 PujaDeshmukh17 left review comments
@vibhutikumar07 vibhutikumar07 Awaiting requested review from vibhutikumar07
@yashmeet29 yashmeet29 Awaiting requested review from yashmeet29
+1 more reviewer
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deepikaSingh2711 @PujaDeshmukh17 @rashmiangadi05