chore: simplify getFlatColumnsFor in cqn4sql#1550
Merged
patricebender merged 4 commits intomainfrom Apr 22, 2026
Merged
Conversation
patricebender
requested review from
BobdenOs,
danjoa,
johannes-vogel,
sjvans and
stewsk
as code owners
simonoswald
reviewed
Apr 10, 2026
| * and proceeds accordingly. If the element is a structure, it recursively fetches flat columns for all sub-elements. | ||
| * If it's an association, it fetches flat columns for it's foreign keys. | ||
| * If it's a scalar, it creates a flat column for it. | ||
| * Structures → flat sub-element columns. Associations → flat foreign key columns. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Structures → flat sub-element columns. Associations → flat foreign key columns. | |
| * Structures → flat sub-element columns. Managed associations → flat foreign key columns. |
BobdenOs
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.