Skip to content

fix: output converters for static input values#1538

Closed
schiwekM wants to merge 27 commits intomainfrom
fix/time-output-converters
Closed

fix: output converters for static input values#1538
schiwekM wants to merge 27 commits intomainfrom
fix/time-output-converters

Conversation

@schiwekM
Copy link
Copy Markdown

While testing the new change tracking plugin with PG & HANA we came across SQL issues related to the output converters for date & time fields.

@schiwekM schiwekM changed the title Fixing output converters for time & dates fix: output converters for time & dates Mar 19, 2026
Comment thread test/compliance/resources/db/basic/projection.cds Outdated
@schiwekM schiwekM requested a review from BobdenOs March 19, 2026 17:02
@schiwekM schiwekM changed the title fix: output converters for time & dates fix: output converters for string values Mar 19, 2026
@schiwekM schiwekM changed the title fix: output converters for string values fix: output converters for string input values Mar 19, 2026
Comment thread postgres/lib/PostgresService.js Outdated
Comment thread sqlite/lib/SQLiteService.js Outdated
Comment thread sqlite/lib/SQLiteService.js Outdated
Comment thread sqlite/lib/SQLiteService.js Outdated
Comment thread test/compliance/resources/db/basic/projection.cds
Comment thread test/compliance/SELECT.test.js Outdated
Comment thread test/compliance/SELECT.test.js Outdated
Comment thread hana/lib/HANAService.js Outdated
schiwekM and others added 3 commits March 20, 2026 09:54
Co-authored-by: Bob den Os <108393871+BobdenOs@users.noreply.github.com>
Co-authored-by: Bob den Os <108393871+BobdenOs@users.noreply.github.com>
Co-authored-by: Bob den Os <108393871+BobdenOs@users.noreply.github.com>
@schiwekM schiwekM closed this Mar 20, 2026
@schiwekM schiwekM reopened this Mar 20, 2026
@schiwekM schiwekM changed the title fix: output converters for string input values fix: output converters for static input values Mar 20, 2026
@schiwekM schiwekM requested a review from BobdenOs March 20, 2026 09:46
@johannes-vogel
Copy link
Copy Markdown
Contributor

@schiwekM Is this PR still required? I don't see that this is needed

@schiwekM
Copy link
Copy Markdown
Author

@johannes-vogel with the remaining change it would only add consistency for the timestamp on sqlite as currently the formatting for timestamp diverges there.
But can be closed as the SQLite behaviour does not need to match HANA/PG I guess.

@schiwekM schiwekM closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants