feat: add sign and execute for extension - #2358
Open
fayi-da wants to merge 1 commit into
Open
Conversation
fayi-da
marked this pull request as ready for review
August 25, 2026 13:17
fayi-da
force-pushed
the
fayi/2303-extension-sign-execute
branch
from
August 26, 2026 09:24
dc9b12c to
8e0e28d
Compare
mjuchli-da
reviewed
Aug 26, 2026
| SignResultSigned, | ||
| } from './rpc-gen/typings.js' | ||
|
|
||
| export class TransactionService { |
Contributor
There was a problem hiding this comment.
Let's extract the service from the remote WG into a core lib and reuse it.
In this instance, we can override the sign method to limit the signing provider.
mjuchli-da
self-requested a review
August 26, 2026 14:25
mjuchli-da
previously approved these changes
Aug 26, 2026
fayi-da
force-pushed
the
fayi/2303-extension-sign-execute
branch
from
August 26, 2026 15:45
8e0e28d to
cf92e99
Compare
Signed-off-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
fayi-da
force-pushed
the
fayi/2303-extension-sign-execute
branch
from
August 26, 2026 16:04
cf92e99 to
9743a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly a copy of remote (slightly stripped down). Will be able to test after the tx and approval stuff is implemented
Closes #2303