Support for installing Sweet Security via pulumi - #6989
Open
isegall-da wants to merge 4 commits into
Open
Conversation
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
martinflorian-da
left a comment
martinflorian-da
left a comment
Contributor
There was a problem hiding this comment.
Let's make this configurable so we have more control about which networks we deploy this to and when 🙏
|
|
||
| configureReloader(); | ||
|
|
||
| configureSweet(); |
Contributor
There was a problem hiding this comment.
Shall we make this configurable? Unlike reloader you (AFAIU) need to pay to be able to use it, so including that without an option to disable (on the public repo) seems a bit weird.
Contributor
There was a problem hiding this comment.
...and also you might want to stagger the deployment so you don't risk breaking all (ci) networks at the same time?
| } from '@canton-network/splice-pulumi-common'; | ||
|
|
||
| export function configureSweet(): k8s.helm.v3.Release { | ||
| const operatorNs = exactNamespace('sweet-operator', false, true); |
Contributor
There was a problem hiding this comment.
Any reason not to use the same namespace for both?
|
|
||
| export function configureSweet(): k8s.helm.v3.Release { | ||
| const operatorNs = exactNamespace('sweet-operator', false, true); | ||
| const sweetNs = exactNamespace('sweet', false, true); |
Contributor
There was a problem hiding this comment.
Why retainOnDelete = true? On both namespaces?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, disabled by default. Tested on a scratchnet, seems to work fine.
Part of https://github.com/DACH-NY/canton-network-internal/issues/6624
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines