Skip to content

Align vote reason URL width and copy with SV IDs (#6914) - #6976

Open
puneetfinoa wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/6914
Open

Align vote reason URL width and copy with SV IDs (#6914)#6976
puneetfinoa wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/6914

Conversation

@puneetfinoa

Copy link
Copy Markdown
Contributor

Summary

  • Make Votes-row vote reason URLs use the same width track as party IDs.
  • Place the URL copy control in the shared copy column so short URLs stay aligned with SV ID copy icons (Figma).
  • Keep the You badge as party ID → You → copy (confirmed with design).

Fixes #6914

Test plan

  • Open proposal details → Votes: URL track matches party-ID width
  • Confirm URL and party-ID copy icons share one vertical edge (short and long URLs)
  • You row: badge stays before the copy icon
  • Attach a Votes-section screenshot (required for frontend PRs)

Screenshots

Screenshot 2026-08-26 at 10 42 14 Screenshot 2026-08-26 at 10 41 48 Screenshot 2026-08-26 at 10 42 35

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Match Votes-row URL track to the party-ID column and place the URL copy
in the shared copy column so short URLs stay aligned with Figma.

Signed-off-by: Puneet Bharti <puneet.bharti@finoa.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change URLs in Votes section of proposal details to be the same length as SV IDs

5 participants