add switch over time field to configs - #6968
Open
JYC11 wants to merge 4 commits into
Open
Conversation
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
meiersi-da
requested changes
Aug 26, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot. This goes in the right direction.
Apart from my comments below I'd like to see a small extension to the test cases for DsoConfig, AmuletConfig, and ExternalPartyConfig which shows that a new switch-over time can be set. Just to be double-sure that the propagation works correctly.
Note also that you'll need to adjust the defaults for the config UI implementation and tests. CI will tell you where.
dfordivam
assigned
dfordivam and unassigned
rautenrieth-da,
ray-roestenburg-da,
isegall-da and
martinflorian-da
meiersi-da
reviewed
Aug 27, 2026
meiersi-da
reviewed
Aug 27, 2026
JYC11
force-pushed
the
jaeyoon/switch-over-times-config
branch
from
August 27, 2026 06:51
c705202 to
78a424f
Compare
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #4249