feat: extract reusable member-traffic reconciliation trigger (Scala)

[sadiq1971]

Rebased onto feat/dedicated-sync now that #14 has merged. The reconciliation logic is SV-shaped today: it asks SynchronizerNodeService for its own sequencer, so there is no way to point it at another synchronizer. This factors the logic out so the Sync Operator Node can run it against a dedicated synchronizer. No behavior change for the SV.

What this does

• New ReconcileSequencerLimitWithMemberTrafficTriggerBase (apps/common/automation), following the existing PackageVettingTrigger pattern: shared logic in an abstract trigger, app-specific dependencies as abstract defs (targetSynchronizerId, sequencerAdminConnection, getTotalPurchasedMemberTraffic, trafficLimitOffset).
• The SV trigger becomes a thin subclass, 175 lines down to 78, binding those hooks to SvDsoStore, SynchronizerNodeService and the synchronizer id already held by SvDsoAutomationService.
• Contracts for other synchronizers are now skipped on a local comparison, before any sequencer RPC. Previously every foreign contract cost a getStatus round trip.

The SV subclass deliberately keeps its name and package. identifyTriggerClassByName returns getCanonicalName and that string keys automationConfig.pausedTriggers, while metrics use getSimpleName as trigger_name. Moving the concrete class would silently change both, including in dashboards and cluster configs outside this repo. Only the reusable logic moves out of singlesv.

One deliberate behavior change

A mismatch between the configured target and the sequencer the connection actually serves is now Status.INTERNAL rather than a skip. After this change those are different conditions: a contract naming another synchronizer is normal and still skips, but the configured target disagreeing with the connection would credit the wrong sequencer, so it should be loud rather than silently granting nothing. This cannot fire from an LSU switchover, which preserves the logical synchronizer id.

How it's verified

apps-sv/compile, scalafmtCheck, headerCheck and scalafix --check pass locally on both apps-common and apps-sv.

No new tests: apps/sv holds 79 triggers and no trigger unit tests. Equivalence rests on the target being the same value the old code compared against, which holds by type (PhysicalSynchronizerId.logical : SynchronizerId) and because SvDsoAutomationService receives the decentralized synchronizer id.

Tracked in

Implements E2-1 (ChainSafe/canton-extending-mainnet#31); unblocks E2-2 (#32).

Note for E2-2: getTotalPurchasedMemberTraffic filters on migration_id, and MemberTraffic ingestion filters on payload.migrationId == domainMigrationId, so an operator node built on this path would inherit #60 and grant nothing on a network past migration 0. #16 avoids that by not matching on the node's own migration id, since a registered synchronizer is pinned to migration id 0.

[timwu20]

A mismatch between the configured target and the sequencer the connection actually serves is now Status.INTERNAL rather than a skip.

The code ships the better version of this — FAILED_PRECONDITION with retryable semantics, so a connection mid-switchover recovers on its own (the in-code comment makes that argument well). Worth updating this paragraph to match so the merged description doesn't contradict the implementation.

[moritzkiefer-da]

Thanks! This overall goes in the right direction but some of the checks are a bit redundant or misplaced. Also left some comments wrt to BFT syncs. I don't think that needs any code changes so more of an FYI•

[sadiq1971]

Thanks! This overall goes in the right direction but some of the checks are a bit redundant or misplaced. Also left some comments wrt to BFT syncs. I don't think that needs any code changes so more of an FYI•

@moritzkiefer-da updated the code

[moritzkiefer-da]

nice thanks