fix(p2p): make P2P gossip mode flag atomic to eliminate a data race#457
Open
amathxbt wants to merge 1 commit into
Open
fix(p2p): make P2P gossip mode flag atomic to eliminate a data race#457amathxbt wants to merge 1 commit into
amathxbt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
P2P.gossip(inp2p/p2p.go) is a plainboolfield read and written from different goroutines without synchronization:SetGossipMode()is called fromControllerincontroller/consensus.go(during must-connect/peer-count updates), whileGossipMode()is read concurrently from multiple other places incontroller/consensus.go(ShouldGossip, and the self-send/replica-broadcast decision in the block-proposal path) as part of normal BFT/consensus operation. These calls happen on different goroutines (consensus loop vs. peer-management callbacks) with no shared lock, which is a genuine unsynchronized concurrent read/write on a plainbool— undefined behavior per the Go memory model, and flagged by the race detector.Fix
Changed
gossipfrombooltoatomic.Booland updatedSetGossipMode/GossipModeto useStore/Load. This is a minimal, drop-in fix:atomic.Bool's zero value isfalse, matching the previous default, and both accessor methods keep their existing signatures so no call sites outside this file need to change.Testing
Confirmed
p.gossipwas only referenced withinp2p/p2p.goviaSetGossipMode/GossipMode, and that all external callers (incontroller/consensus.go) only go through these two methods, so the internal type change is fully encapsulated.