build: run docs-clean as part of clean target - #594
Merged
Conversation
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
6 tasks
bepri
approved these changes
Aug 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the top-level make clean target so it also cleans documentation build/dev artifacts (via docs-clean), aligning clean with other top-level targets that already interact with the docs tooling.
Changes:
- Make
cleandepend ondocs-cleanso doc dev artifacts (e.g.,docs/_dev/styles/) are removed as part of a standard clean.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other top-level targets, like
make lint, target the docs.make cleanshould follow the same pattern.I was having an issue where
make lint-docswas only failing in CI. The problem was thatdocs/_dev/styles/was out-of-date andmake cleanwasn't cleaning it.Source: canonical/snapcraft#6391 (comment)
make lint && make test.