Skip to content

Change alert evaluation time of PostgresqlHighRollbackRate from 0m to 5m #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggouzi wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Change alert evaluation time of PostgresqlHighRollbackRate from 0m to 5m #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/prometheus_alert_rules/postgresql_rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ groups:
# 2.2.9
- alert: PostgresqlHighRollbackRate
expr: 'sum by (namespace,datname,instance,datid) ((rate(pg_stat_database_xact_rollback{datname!~"template.*|postgres",datid!="0"}[3m])) / ((rate(pg_stat_database_xact_rollback{datname!~"template.*|postgres",datid!="0"}[3m])) + (rate(pg_stat_database_xact_commit{datname!~"template.*|postgres",datid!="0"}[3m])))) > 0.02'
for: 0m
for: 5m
labels:
severity: warning
annotations:
Expand Down
16 changes: 8 additions & 8 deletions tests/alerts/test_postgresql_rules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,12 @@ tests:
interval: 1m
input_series:
- series: 'pg_stat_database_xact_rollback{instance="pg1",datname="appdb",datid="1"}'
values: '10 20 30'
values: '10 20 30 40 50 60 70 80 90'
- series: 'pg_stat_database_xact_commit{instance="pg1",datname="appdb",datid="1"}'
values: '10 10 10'
values: '10 10 10 10 10 10 10 10 10'
alert_rule_test:
- alertname: PostgresqlHighRollbackRate
eval_time: 3m
eval_time: 8m
exp_alerts:
- exp_labels:
alertname: PostgresqlHighRollbackRate
Expand All @@ -286,12 +286,12 @@ tests:
interval: 1m
input_series:
- series: 'pg_stat_database_xact_rollback{instance="pg2",datname="appdb",datid="2"}'
values: '1 1 1'
values: '1 1 1 1 1 1 1 1 1'
- series: 'pg_stat_database_xact_commit{instance="pg2",datname="appdb",datid="2"}'
values: '100 100 100'
values: '100 100 100 100 100 100 100 100 100'
alert_rule_test:
- alertname: PostgresqlHighRollbackRate
eval_time: 3m
eval_time: 8m
exp_alerts: []

# 2.2.10
Expand All @@ -310,7 +310,7 @@ tests:
instance: pg1
datname: appdb
exp_annotations:
summary: PostgreSQL instance pg1 has a low commit rate.
summary: PostgreSQL instance pg1 has a low commit rate.
description: |
PostgreSQL seems to be processing very few transactions.
Please check for long-running queries and configuration issues, like insufficient cache size.
Expand Down Expand Up @@ -676,7 +676,7 @@ tests:
relname: orders
indexrelname: orders_ccnew_idx
exp_annotations:
summary: PostgreSQL instance pg1)= has an invalid index.
summary: PostgreSQL instance pg1)= has an invalid index.
description: |
The table orders has an invalid index: orders_ccnew_idx.
Consider running `DROP INDEX orders_ccnew_idx;`
Expand Down
Loading