[DPE-10454] Use better status instead of blocked for transient update failures#1795
Open
taurus-forever wants to merge 1 commit into
Open
[DPE-10454] Use better status instead of blocked for transient update failures#1795taurus-forever wants to merge 1 commit into
taurus-forever wants to merge 1 commit into
Conversation
… failures Use maintenance/waiting status instead of blocked one. The 'failed to update cluster members on member' BlockedStatus was misleading: these are transient, self-recovering conditions (a RetryError from update_config(), or a peer IP not yet published) rather than states needing operator intervention. Replace them with MaintenanceStatus / WaitingStatus and a 'pending update cluster members on member' message. Update test_on_peer_relation_changed accordingly, and set an explicit BlockedStatus before exercising the early-exit guard so that path stays covered. Assisted-by: Claude:claude-4.8-opus
github-actions
Bot
added
the
Libraries: Out of sync
taurus-forever
commented
Jun 23, 2026
| self.set_unit_status(MaintenanceStatus("pending update cluster members on member")) | ||
| else: | ||
| self.set_unit_status(BlockedStatus("failed to update cluster members on member")) | ||
| self.set_unit_status(WaitingStatus("pending update cluster members on member")) |
Contributor
Author
There was a problem hiding this comment.
Using WaitingStatus here as a flag to recognize RetryError==MaintenanceStatus.
Should I sync all to the same status?
Member
There was a problem hiding this comment.
What if we have something like WaitingStatus("waiting for peer IP") here and MaintenanceStatus("updating cluster members") in L1415 and L1196 to make the status messages correspond to each state?
taurus-forever
requested review from
carlcsaposs-canonical,
dragomirp,
juju-charm-bot and
marceloneppel
and removed request for
a team
dragomirp
approved these changes
Jun 23, 2026
dragomirp
reviewed
Jun 23, 2026
| _update_config.assert_called_once_with() | ||
| assert isinstance(harness.charm.unit.status, BlockedStatus) | ||
| assert harness.charm.unit.status.message == "failed to update cluster members on member" | ||
| assert isinstance(harness.charm.unit.status, MaintenanceStatus | WaitingStatus) |
Contributor
There was a problem hiding this comment.
Better to assert the exact status we are expecting here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use maintenance/waiting status instead of blocked one.
The 'failed to update cluster members on member' BlockedStatus was misleading: these are transient, self-recovering conditions (a RetryError from update_config(), or a peer IP not yet published) rather than states needing operator intervention. Replace them with MaintenanceStatus / WaitingStatus and a 'pending update cluster members on member' message.
Update test_on_peer_relation_changed accordingly, and set an explicit BlockedStatus before exercising the early-exit guard so that path stays covered.
Assisted-by: Claude:claude-4.8-opus