Skip to content

fix(backups): configure pgBackRest stderr logging #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanookclaw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(backups): configure pgBackRest stderr logging #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/pgbackrest.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
backup-standby=y
compress-type=zst
lock-path=/tmp
log-level-stderr=warn
log-path={{ log_path }}
repo1-retention-full-type=time
repo1-retention-full={{ retention_full }}
Expand Down
7 changes: 7 additions & 0 deletions tests/unit/test_backups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1870,6 +1870,13 @@ def test_render_pgbackrest_conf_file(harness, tls_ca_chain_filename):

# Check the template is opened read-only in the call to open.
assert mock.call_args_list[0][0] == ("templates/pgbackrest.conf.j2",)
rendered_pgbackrest_conf = next(
call_args[0][1]
for call_args in _render_file.call_args_list
if call_args[0][0]
== "/var/snap/charmed-postgresql/current/etc/pgbackrest/pgbackrest.conf"
)
assert "log-level-stderr=warn" in rendered_pgbackrest_conf

# Get the expected content from a file.
with open("templates/pgbackrest.conf.j2") as file:
Expand Down
Loading