Skip to content

ci: use artifacts by default for test image builds - #1043

Draft
yanksyoon wants to merge 1 commit into
canonical:mainfrom
yanksyoon:fix/isd-512-artifact-default
Draft

ci: use artifacts by default for test image builds#1043
yanksyoon wants to merge 1 commit into
canonical:mainfrom
yanksyoon:fix/isd-512-artifact-default

Conversation

@yanksyoon

Copy link
Copy Markdown
Member

Summary

  • Use GitHub Actions artifacts instead of GHCR for default test-event image builds.
  • Keep upload-image: registry as an explicit opt-in for tests requiring a remote image.
  • Add configurable 30-day artifact retention.
  • Provision a local registry for legacy artifact-based integration tests.
  • Update action bundles, documentation, and changelog.

This addresses ISD-512 by preventing routine pull-request and test builds from creating persistent GHCR versions.

Test plan

  • npm run lint
  • npm run format:check
  • npm run package
  • YAML parsing and static workflow checks

@yanksyoon
yanksyoon force-pushed the fix/isd-512-artifact-default branch from 7190274 to 52da37f Compare August 26, 2026 14:33

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments.

Comment thread docs/changelog.md
Comment on lines +5 to +8
## Unreleased

- Default integration-test image builds to artifact mode for pull requests, scheduled tests, and manual runs, with a configurable 30-day artifact retention period. Use `upload-image: registry` when a remote GHCR image is required.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set the release date to 2026-08-08

@yanksyoon
yanksyoon force-pushed the fix/isd-512-artifact-default branch 3 times, most recently from 7ac72c8 to 5f26d89 Compare August 28, 2026 02:12
@yanksyoon
yanksyoon force-pushed the fix/isd-512-artifact-default branch from 5f26d89 to 058a2c7 Compare August 28, 2026 02:40
@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit 058a2c7

Test coverage for 058a2c7

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-08-28 02:41:25.120930+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit 058a2c7

Test coverage for 058a2c7

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-08-28 02:44:28.227256+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit 058a2c7

Test coverage for 058a2c7

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-08-28 02:41:20.200265+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant