[daemon] List/Info: Skip runtime info if no IP - #5239
Merged
Merged
Conversation
Skip attempting to obtain runtime info when no management IP is present for a VM. This allows commands like list/info to succeed even when there's a VM with no mgmt IP. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
requested review from
a team,
Laefy and
ricab
and removed request for
a team and
ricab
September 11, 2026 21:59
xmkg
marked this pull request as ready for review
September 11, 2026 21:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5239 +/- ##
==========================================
+ Coverage 72.62% 72.62% +0.01%
==========================================
Files 337 337
Lines 18190 18189 -1
==========================================
Hits 13208 13208
+ Misses 4982 4981 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Laefy
reviewed
Sep 14, 2026
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Laefy
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip attempting to obtain runtime info when no management IP is present
for a VM. This allows commands like list/info to succeed even when
there's a VM with no mgmt IP.
Closes #5061
MULTI-2896