[base-vm] Check VM state in ssh_exec_process - #5237
Open
xmkg wants to merge 2 commits into
Open
Conversation
The VM might have been shut down while the cached session is alive and given that the SSH session's established state does not have a timeout it might wedge the caller fovever. Check if VM is running before proceeding with the exec.
xmkg
requested review from
a team and
tobe2098
and removed request for
a team
September 11, 2026 18:52
xmkg
commented
Sep 11, 2026
| make_common_file_rollback(head_path, | ||
| head_file, | ||
| std::to_string(head_snapshot->get_parents_index()) + "\n"); | ||
| auto head_file_rollback = make_common_file_rollback( |
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5237 +/- ##
==========================================
+ Coverage 72.62% 72.63% +0.02%
==========================================
Files 337 337
Lines 18190 18195 +5
==========================================
+ Hits 13208 13215 +7
+ Misses 4982 4980 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VM might have been shut down while the cached session is alive, and given that the SSH session's established state does not have a timeout, it might wedge the caller forever.
Check if the VM is running before proceeding with the exec.
Related Issue(s)
#5235