[hcs] Remove COM port device from serial - #5222
Conversation
Attaching a COM port device to the serial output adversely affects the boot time as the Linux kernel defaults to 9600 baud and there is no clean way to change that. Removing the COM port device and the named pipe for the time being as it was a troubleshooting escape hatch anyway. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
There was a problem hiding this comment.
🟡 Changes recommended
Existing exact-JSON unit tests will fail until their COM-port expectations are updated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes HCS serial COM-port configuration to improve VM boot time.
Changes:
- Removes the UEFI COM-port console.
- Removes the named-pipe COM-port device.
File summaries
| File | Review |
|---|---|
src/platform/backends/hyperv_api/hcs/hyperv_hcs_create_compute_system_params.cpp |
Removes COM-port configuration from generated HCS JSON. Critical: update all six exact-JSON unit-test expectations to match. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
There was a problem hiding this comment.
🟢 Approval recommended
The only remaining feedback is a non-blocking formatter-argument cleanup.
Review details
Suppressed comments (1)
src/platform/backends/hyperv_api/hcs/hyperv_hcs_create_compute_system_params.cpp:73
- Removing the only
{2}substitution leavesparams.nameas an unused formatting argument and the remaining placeholders starting at{3}. This makes the formatter’s argument mapping misleading; please renumber{3}–{6}to{2}–{5}and removeparams.namefrom theformat_tocall.
}}
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5222 +/- ##
=======================================
Coverage 72.63% 72.63%
=======================================
Files 337 337
Lines 18196 18196
=======================================
Hits 13214 13214
Misses 4982 4982 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Attaching a COM port device to the serial output adversely affects the boot time (adds around ~50s), as the Linux kernel defaults to 9600 baud and there is no clean way to change that.
Removing the COM port device and the named pipe for the time being, as it was a troubleshooting escape hatch anyway.