Skip to content

[hcs] Remove COM port device from serial - #5222

Open
xmkg wants to merge 2 commits into
mainfrom
bugfix/hcs-remove-com-port-device
Open

[hcs] Remove COM port device from serial#5222
xmkg wants to merge 2 commits into
mainfrom
bugfix/hcs-remove-com-port-device

Conversation

@xmkg

@xmkg xmkg commented Sep 8, 2026

Copy link
Copy Markdown
Member

Attaching a COM port device to the serial output adversely affects the boot time (adds around ~50s), as the Linux kernel defaults to 9600 baud and there is no clean way to change that.

Removing the COM port device and the named pipe for the time being, as it was a troubleshooting escape hatch anyway.

Attaching a COM port device to the serial output adversely affects the
boot time as the Linux kernel defaults to 9600 baud and there is no
clean way to change that.

Removing the COM port device and the named pipe for the time being as
it was a troubleshooting escape hatch anyway.

Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
@xmkg
xmkg requested review from a team and sharder996 and a balanced review from Copilot and removed request for a team September 8, 2026 17:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Existing exact-JSON unit tests will fail until their COM-port expectations are updated.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Removes HCS serial COM-port configuration to improve VM boot time.

Changes:

  • Removes the UEFI COM-port console.
  • Removes the named-pipe COM-port device.
File summaries
File Review
src/platform/backends/hyperv_api/hcs/hyperv_hcs_create_compute_system_params.cpp Removes COM-port configuration from generated HCS JSON. Critical: update all six exact-JSON unit-test expectations to match.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Copilot AI review requested due to automatic review settings September 8, 2026 17:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The only remaining feedback is a non-blocking formatter-argument cleanup.

Review details

Suppressed comments (1)

src/platform/backends/hyperv_api/hcs/hyperv_hcs_create_compute_system_params.cpp:73

  • Removing the only {2} substitution leaves params.name as an unused formatting argument and the remaining placeholders starting at {3}. This makes the formatter’s argument mapping misleading; please renumber {3}{6} to {2}{5} and remove params.name from the format_to call.
                    }}
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.63%. Comparing base (3d5114a) to head (306c51c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5222   +/-   ##
=======================================
  Coverage   72.63%   72.63%           
=======================================
  Files         337      337           
  Lines       18196    18196           
=======================================
  Hits        13214    13214           
  Misses       4982     4982           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xmkg xmkg added this to the 1.17.0 milestone Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants