chore: switch from MariaDB to MySQL - #25
Draft
swetha1654 wants to merge 13 commits into
Draft
Conversation
Update the charm and rock to use mysql-k8s instead of mariadb-k8s. The canonical/frappe fork (branch version-16-mysql) adds MySQL support to Frappe, allowing us to use the production-ready mysql-k8s charm. Changes: - rockcraft.yaml: Use canonical/frappe fork with mysql support, replace mariadb dev/runtime packages with mysql equivalents - src/workload.py: Use --db-type mysql for bench new-site - tests: Replace mariadb-k8s references with mysql-k8s - terraform: Update module to deploy mysql-k8s - docs/README: Update all MariaDB references to MySQL Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Temporarily point to feat/version-16-mysql-support-ISD-6236 branch on canonical/frappe until the changes are merged into version-16-mysql. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mysql-k8s uses ubuntu@22.04 base and revision 423 on 8.0/stable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The previous sed accidentally changed redis channel to 8.0/stable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
libmysqlclient21 is not available in the Ubuntu 26.04 archive used by rockcraft. The mariadb client libraries (libmariadb3, libmariadb-dev) are wire-compatible with MySQL servers and work correctly for the mysqlclient Python package. The key MySQL support comes from the canonical/frappe fork at the application level. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When bench new-site --no-setup-db creates site_config.json but the database tables don't exist yet, bench list-apps fails with a 'doesn't exist' error in stdout. Handle this gracefully by returning an empty dict, allowing setup_hrms to proceed with site creation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
swetha1654
marked this pull request as draft
August 20, 2026 09:23
Collaborator
Author
|
This PR will not be merged as we decided to stop working on HRMS charm altogether until we find a better opensource alternative to Frappe HR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the HRMS charm from the vibe-coded mariadb-k8s charm to the production-ready mysql-k8s charm, using the canonical/frappe fork (branch
version-16-mysql) that adds MySQL support to Frappe.Changes
canonical/frappefork (version-16-mysqlbranch), replace mariadb dev/runtime packages with mysql equivalents--db-type mysqlforbench new-sitemysql_client)mariadb-k8sreferences withmysql-k8smysql-k8s(channel8.0/stable)Notes
databaserelation interface (mysql_client) is unchanged — both mariadb-k8s and mysql-k8s support itversion-16-mysql