refactor(garm): make teardown the shared cleanup coordinator - #334
Draft
yanksyoon wants to merge 1 commit into
Draft
refactor(garm): make teardown the shared cleanup coordinator#334yanksyoon wants to merge 1 commit into
yanksyoon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This child PR is stacked on #333 and refactors the existing removal cleanup into the shared
_teardown()orchestrator._on_remove()to_teardown()._reconcile(), PostgreSQLrelation-departed,stop, andremove.planned_units() > 0.Relation-independent teardown
_teardown()uses only:planned_units()and leadership;GarmResourceCleanupAPI coordinator.The old fallback that called
_get_postgresql_config()when GARM was unreachable has been removed. Late teardown now logs an unconfirmed result and returns instead of reading a relation that may already be broken.Pre-break
relation-departedfailures remain strict and raiseGarmCleanupErrorso Juju can retry. Latestop,remove, and other teardown attempts tolerate unavailable API/database/credentials.Idempotency
_teardown_claimedprevents duplicate cleanup attempts from multiple observers in one hook process, notably the twoupdate-statusobservers.GarmResourceCleanupdisables resources before deletion, polls asynchronous runner removal, and treats already-missing resources as success.Validation
tox -c tox.toml -e unit— 266 passedgit diff --check— passedReview focus
_teardown()is intentionally global and leader-only, matching the existing_on_remove()behavior.