Skip to content

Pin canonical/charm-ci to v1.0.0 and make opcli Renovate-manageable - #24

Merged
javierdelapuente merged 2 commits into
mainfrom
chore/pin-charm-ci-v1.0.0
Aug 26, 2026
Merged

Pin canonical/charm-ci to v1.0.0 and make opcli Renovate-manageable#24
javierdelapuente merged 2 commits into
mainfrom
chore/pin-charm-ci-v1.0.0

Conversation

@javierdelapuente

@javierdelapuente javierdelapuente commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR upgrades the monorepo's canonical/charm-ci pins to the stable v1.0.0 release and fixes the two sub-charm opcli declarations so Renovate can track them instead of silently ignoring inline git URLs.

Problem

Both cloudflared-operator/pyproject.toml and cloudflare-configurator-operator/pyproject.toml declared opcli inline as:

"opcli @ git+https://github.com/canonical/charm-ci.git@v0.0.1-alpha.3"

That format is not visible to Renovate's pep621/uv handling, so the opcli git pin could drift independently from the reusable workflow refs. This repo had already drifted across files (v0.0.1-alpha.3 in pyprojects vs v0.0.1-alpha.6 in workflows).

Fix

  • moved opcli into [tool.uv.sources] in both sub-charm pyproject.toml files, keeping the dependency entry as plain "opcli"
  • bumped both sub-charms to tag = "v1.0.0" and regenerated both uv.lock files so they now pin commit 0eef5b8cbef3ee74907850f790cab64bcf0499e5
  • pinned .github/workflows/tests.yaml and .github/workflows/publish.yaml to canonical/charm-ci commit 0eef5b8cbef3ee74907850f790cab64bcf0499e5 # v1.0.0
  • added a Renovate packageRules group so the opcli git dependency and canonical/charm-ci workflow refs stay in lockstep going forward
  • added the required hidden release-note artifact for this repo's PR compliance workflow

Testing

  • uv lock in cloudflared-operator/
  • uv lock in cloudflare-configurator-operator/
  • python3 -c "import json; json.load(open('renovate.json'))"

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

@javierdelapuente
javierdelapuente requested a review from a team as a code owner August 24, 2026 13:29
@javierdelapuente
javierdelapuente requested review from danielvnguyen and yhaliaw and removed request for a team August 24, 2026 13:29
@javierdelapuente javierdelapuente added the no-release-note This PR does not require a change artifact label Aug 24, 2026
@javierdelapuente
javierdelapuente force-pushed the chore/pin-charm-ci-v1.0.0 branch from 2324834 to 1d2e457 Compare August 24, 2026 13:33
@javierdelapuente javierdelapuente removed the no-release-note This PR does not require a change artifact label Aug 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 114 files.

Valid Invalid Ignored Fixed
32 1 81 0
Click to see the invalid file list
  • docs/release-notes/artifacts/pin-charm-ci-v1.0.0.yaml
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@javierdelapuente
javierdelapuente force-pushed the chore/pin-charm-ci-v1.0.0 branch from 1d2e457 to 2267f81 Compare August 24, 2026 13:36
@javierdelapuente javierdelapuente added no-release-note This PR does not require a change artifact and removed Libraries: Out of sync labels Aug 24, 2026
…tead

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit e44abde

Test coverage for e44abde

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      69      0     20      0   100%
----------------------------------------------------------
TOTAL             69      0     20      0   100%

Static code analysis report

Run started:2026-08-24 15:51:02.704264+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 509
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@github-actions

Copy link
Copy Markdown
Contributor

Test results for commit e44abde

Test coverage for e44abde

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     159     62     52      5    57%   88-89, 112->114, 117-156, 164, 176-185, 212, 221-226, 234-247, 256-266, 283-293, 303-306, 325
----------------------------------------------------------
TOTAL            159     62     52      5    57%

Static code analysis report

Run started:2026-08-24 15:51:01.783926+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 800
  Total lines skipped (#nosec): 7
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@javierdelapuente
javierdelapuente merged commit e2e4fc7 into main Aug 26, 2026
37 checks passed
@javierdelapuente
javierdelapuente deleted the chore/pin-charm-ci-v1.0.0 branch August 26, 2026 06:49

@yhaliaw yhaliaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved


🤝 Human review with AI assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync no-release-note This PR does not require a change artifact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants