Pin canonical/charm-ci to v1.0.0 and make opcli Renovate-manageable - #24
Merged
Conversation
javierdelapuente
requested review from
danielvnguyen and
yhaliaw
and removed request for
a team
August 24, 2026 13:29
javierdelapuente
force-pushed
the
chore/pin-charm-ci-v1.0.0
branch
from
August 24, 2026 13:33
2324834 to
1d2e457
Compare
Contributor
There was a problem hiding this comment.
license-eye has checked 114 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 32 | 1 | 81 | 0 |
Click to see the invalid file list
- docs/release-notes/artifacts/pin-charm-ci-v1.0.0.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
javierdelapuente
force-pushed
the
chore/pin-charm-ci-v1.0.0
branch
from
August 24, 2026 13:36
1d2e457 to
2267f81
Compare
…tead Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Test results for commit e44abdeTest coverage for e44abde Static code analysis report |
Contributor
Test results for commit e44abdeTest coverage for e44abde Static code analysis report |
danielvnguyen
approved these changes
Aug 25, 2026
yhaliaw
approved these changes
Aug 26, 2026
yhaliaw
left a comment
There was a problem hiding this comment.
Approved
🤝 Human review with AI assistance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the monorepo's
canonical/charm-cipins to the stablev1.0.0release and fixes the two sub-charmopclideclarations so Renovate can track them instead of silently ignoring inline git URLs.Problem
Both
cloudflared-operator/pyproject.tomlandcloudflare-configurator-operator/pyproject.tomldeclaredopcliinline as:"opcli @ git+https://github.com/canonical/charm-ci.git@v0.0.1-alpha.3"That format is not visible to Renovate's pep621/uv handling, so the
opcligit pin could drift independently from the reusable workflow refs. This repo had already drifted across files (v0.0.1-alpha.3in pyprojects vsv0.0.1-alpha.6in workflows).Fix
opcliinto[tool.uv.sources]in both sub-charmpyproject.tomlfiles, keeping the dependency entry as plain"opcli"tag = "v1.0.0"and regenerated bothuv.lockfiles so they now pin commit0eef5b8cbef3ee74907850f790cab64bcf0499e5.github/workflows/tests.yamland.github/workflows/publish.yamltocanonical/charm-cicommit0eef5b8cbef3ee74907850f790cab64bcf0499e5 # v1.0.0packageRulesgroup so theopcligit dependency andcanonical/charm-ciworkflow refs stay in lockstep going forwardTesting
uv lockincloudflared-operator/uv lockincloudflare-configurator-operator/python3 -c "import json; json.load(open('renovate.json'))"Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com