Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the prereadable connection #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the prereadable connection #47
Changes from all commits
b1cfe7dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ReadFrompanics unconditionally here, andWriteTodoes the same at lines 113-116. Because*net.TCPConnis embedded (line 26),*Connsatisfies bothio.ReaderFromandio.WriterTo, andio.Copychecks those interfaces before falling back toRead/Write.That means
io.Copy(dst, conn)andio.Copy(conn, src)panic on the very first call. The repo's existing relay,RelayTCPinaproxy.go(lines 277 and 284), is built on exactly those twoio.Copycalls, and there's norecover()anywhere outside test code — an unrecovered panic in a per-connection goroutine takes down the whole daemon. This PR doesn't wireConninto the relay path yet, so nothing breaks today, but it's a landmine for the follow-up PR.The cleanest fix is to stop embedding
*net.TCPConnand instead hold it as an unexported field, forwarding only the safe methods (Close,CloseWrite,LocalAddr,RemoteAddr, the deadline setters). That removesReadFrom/WriteTofrom the method set entirely soio.Copyfalls back to buffered copying. If embedding needs to stay for another reason, at minimum return an error instead of panicking soio.Copysurfaces a normal error rather than crashing the process.🤖 AI-assisted
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.