This repository was archived by the owner on Nov 21, 2019. It is now read-only.
F/aftersetattributes event#41
Open
mrbig wants to merge 1 commit into
Open
Conversation
EMongoEmbeddedDocument raises a new event called afterSetAttributes. This is raised after the attributes of the document have been set. EEmbeddedArraysBehavior changed to populate the items on this event. This makes it more robust when attached to embedded documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Yet another refactor to the EEmbeddedArraysBehavior. The behavior did not work on embedded documents: it tried to load the attributes before the setAttributes was called.
Now EMongoEmbeddedDocument raises a new event called afterSetAttributes. This
is raised after the attributes of the document have been set.
EEmbeddedArraysBehavior changed to populate the items on this event. This
makes it more robust when attached to embedded documents.
I'll add some testcases for this in the test suite hopefully in a few days. This fix has been tested on out project that has many different use of the EmbeddedArraysBehavior, and didn't brake anything, so seems safe to me.