Update stall sprite sheet and registry offsets - #79
Conversation
- Replaced stalls.png with a new version where stalls are spaced 500px apart vertically.
- Updated IntRect coordinates in StallRegistry for all active stalls:
- Teh Tarik (Index 0)
- Chicken Rice (Index 1)
- Durian (Index 2)
- Satay (Index 3)
- Ice Kachang (Index 4)
- Tray Return Uncle (Index 6)
- Preserved existing sprite dimensions and internal padding within the new 500px slots.
- Skipped Index 5 (Bak Kut Teh) as requested.
- Removed placeholder note for Tray Return Uncle.
Co-authored-by: candour <4670475+candour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughWalkthroughUpdated sprite texture atlas coordinates for five stall types in StallRegistry (SATAY, CHICKEN_RICE, DURIAN, ICE_KACHANG, TRAY_RETURN_UNCLE) to reference new positions in the sprite sheet. Removed the stall verification HTML report file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/src/main/java/com/messark/hawker/registry/Registry.kt (1)
325-405: Consider extracting sprite slot stride/padding constants.These hardcoded Y values are correct now, but defining shared constants (e.g., slot stride/padding) would make future atlas updates safer and clearer.
♻️ Suggested refactor
object StallRegistry { + private const val STALL_SLOT_STRIDE_Y = 500 + private const val STALL_BASE_PADDING_Y = 41 + private val definitions = mapOf( StallType.TEH_TARIK to StallDefinition( @@ - spriteRect = IntRect(14, 1541, 322, 1951), + spriteRect = IntRect(14, STALL_BASE_PADDING_Y + 3 * STALL_SLOT_STRIDE_Y, 322, 1951), @@ - spriteRect = IntRect(22, 541, 330, 971) + spriteRect = IntRect(22, STALL_BASE_PADDING_Y + 1 * STALL_SLOT_STRIDE_Y, 330, 971) @@ - spriteRect = IntRect(33, 1041, 341, 1398), + spriteRect = IntRect(33, STALL_BASE_PADDING_Y + 2 * STALL_SLOT_STRIDE_Y, 341, 1398), @@ - spriteRect = IntRect(14, 2041, 322, 2471), + spriteRect = IntRect(14, STALL_BASE_PADDING_Y + 4 * STALL_SLOT_STRIDE_Y, 322, 2471), @@ - spriteRect = IntRect(14, 3041, 322, 3471), + // Slot index 5 intentionally unused (Bak Kut Teh) + spriteRect = IntRect(14, STALL_BASE_PADDING_Y + 6 * STALL_SLOT_STRIDE_Y, 322, 3471),
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c643c474-1a2b-4fbb-8054-e449cde7f3ab
⛔ Files ignored due to path filters (5)
app/src/main/res/drawable-nodpi/stalls.pngis excluded by!**/*.pngstall_verification/chicken_rice.pngis excluded by!**/*.pngstall_verification/ice_kachang.pngis excluded by!**/*.pngstall_verification/satay.pngis excluded by!**/*.pngstall_verification/teh_tarik.pngis excluded by!**/*.png
📒 Files selected for processing (2)
app/src/main/java/com/messark/hawker/registry/Registry.ktstall_verification/index.html
💤 Files with no reviewable changes (1)
- stall_verification/index.html
1 participant
This PR replaces the
stalls.pngsprite sheet with a new single-column version where each stall slot is exactly 500 pixels apart. TheStallRegistryinRegistry.kthas been updated to use the new vertical offsets (e.g.,y = index * 500 + padding) while maintaining the original sprite dimensions and internal padding for each stall.Stalls updated:
The Bak Kut Teh stall (Index 5) is present in the sprite sheet but currently unused in the registry per instructions.
PR created automatically by Jules for task 12607590349002178598 started by @candour
Summary by CodeRabbit
Release Notes