Skip to content

Stats - #194

Merged
candour merged 2 commits into
mainfrom
stats
Jun 26, 2026
Merged

Stats#194
candour merged 2 commits into
mainfrom
stats

Conversation

@candour

@candour candour commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation

    • Updated gameplay reference docs to reflect current stat scaling, milestone behavior, and revised health values for listed enemies and stalls.
    • Clarified table formatting and aligned stat entries for easier reading.
  • Bug Fixes

    • Adjusted health scaling values so enemy health grows at the updated rate.
    • Corrected one character’s base health value in the stats reference.
  • Tests

    • Updated automated game-state tests to initialize in the active gameplay screen for more reliable validation.

Your Name added 2 commits June 26, 2026 13:00
@candour
candour merged commit 207bc2c into main Jun 26, 2026
2 of 3 checks passed
@candour
candour deleted the stats branch June 26, 2026 05:08
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fb38e1da-8d4c-4e2d-8664-a1470bb28990

📥 Commits

Reviewing files that changed from the base of the PR and between 5a19431 and 908f16a.

📒 Files selected for processing (6)
  • AGENTS.md
  • CUSTOMER_STATS.md
  • STALL_STATS.md
  • app/src/main/java/com/messark/hawker/registry/Registry.kt
  • app/src/test/java/com/messark/hawker/StallStatsTest.kt
  • app/src/test/java/com/messark/hawker/UndeadEnemyTest.kt

📝 Walkthrough

Walkthrough

Updated scaling-related documentation and tables, changed customer and enemy HP growth constants to 1.06, and added explicit game-screen initialization to related tests.

Changes

Gameplay scaling updates

Layer / File(s) Summary
Scaling guidance and stall stats
AGENTS.md, STALL_STATS.md
The stall scaling guidance now points readers to the code, and the stall statistics table updates selected base-damage and boost values plus table formatting.
Customer and enemy HP scaling
CUSTOMER_STATS.md, app/src/main/java/com/messark/hawker/registry/Registry.kt
The customer stats table changes Tiger Mom base HP, the customer health-scaling formula uses a 1.06 multiplier, and enemy wave HP in Registry.kt uses the same factor.
Game-state test initialization
app/src/test/java/com/messark/hawker/StallStatsTest.kt, app/src/test/java/com/messark/hawker/UndeadEnemyTest.kt
The stall stats tests and undead enemy test now construct GameState with currentScreen set to AppScreen.GAME.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • candour/towerpower#189: Also changes EnemyDefinition.getHp(wave) in Registry.kt by adjusting the wave HP growth factor.
  • candour/towerpower#141: Touches EnemyDefinition HP typing and getHp implementation in the same registry code path.
  • candour/towerpower#181: Updates Tiger Mom base HP and related balance values in Registry.kt, overlapping the same stats area.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stats

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant