Skip to content

Synchronize base stats and enemy HP scaling across code and docs - #192

Closed
candour wants to merge 1 commit into
mainfrom
fix-stats-consistency-1277115244311179560
Closed

Synchronize base stats and enemy HP scaling across code and docs#192
candour wants to merge 1 commit into
mainfrom
fix-stats-consistency-1277115244311179560

Conversation

@candour

@candour candour commented Jun 18, 2026

Copy link
Copy Markdown
Owner

This change synchronizes the game's core statistics (base damage, base health, and health scaling) between the implementation in Registry.kt and the documentation in STALL_STATS.md, CUSTOMER_STATS.md, and AGENTS.md.

Key adjustments include:

  • Setting Chicken Rice base damage to 10f and Durian base damage to 150f.
  • Setting Tiger Mom base HP to 80f.
  • Standardizing enemy HP scaling at 7% per wave (1.07) across all systems.
  • Correcting documentation examples to use the correct base stats and scaling formulas.

Additionally, this patch fixes two unit tests (StallStatsTest and UndeadEnemyTest) that were failing due to missing currentScreen = AppScreen.GAME initialization in their manually constructed state flows.


PR created automatically by Jules for task 1277115244311179560 started by @candour

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Corrected customer health scaling documentation and base stats examples
  • Balance Changes

    • Updated enemy health scaling formula for wave progression
    • Adjusted Tiger Mom base health value
    • Modified Chicken Rice and Durian stall damage values

…docs

- Updated Registry.kt base stats: Chicken Rice (10f), Durian (150f), Tiger Mom (80f).
- Updated Registry.kt HP scaling factor from 1.05 to 1.07.
- Updated AGENTS.md to reflect 1.07 HP scaling (corrected from 1.1).
- Corrected Auntie HP example in CUSTOMER_STATS.md (using base 135).
- Fixed StallStatsTest and UndeadEnemyTest setups to set currentScreen to GAME.
- Added entry to fixes.md.

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ddf8160a-65f9-4d8c-8774-a3d96890869a

📥 Commits

Reviewing files that changed from the base of the PR and between 5a19431 and f0f4f19.

📒 Files selected for processing (6)
  • AGENTS.md
  • CUSTOMER_STATS.md
  • app/src/main/java/com/messark/hawker/registry/Registry.kt
  • app/src/test/java/com/messark/hawker/StallStatsTest.kt
  • app/src/test/java/com/messark/hawker/UndeadEnemyTest.kt
  • fixes.md

📝 Walkthrough

Walkthrough

Corrects combat balance constants in Registry.kt: enemy HP scaling exponent changes from 1.05 to 1.07, Tiger Mom base HP increases from 60f to 80f, Chicken Rice damage drops from 20f to 10f, and Durian damage rises from 100f to 150f. Documentation examples in AGENTS.md and CUSTOMER_STATS.md are updated to match, tests gain currentScreen = AppScreen.GAME in GameState initialization, and fixes.md logs the correction as FIX-017.

Changes

Balance Stat Corrections and Documentation Sync

Layer / File(s) Summary
Registry.kt combat constant adjustments
app/src/main/java/com/messark/hawker/registry/Registry.kt
HP scaling exponent in EnemyDefinition.getHp changed from 1.05 to 1.07; CHICKEN_RICE damage reduced from 20f to 10f; DURIAN damage increased from 100f to 150f; TIGER_MOM baseHp raised from 60f to 80f.
Documentation formula and example corrections
AGENTS.md, CUSTOMER_STATS.md, fixes.md
Spawning difficulty formula in AGENTS.md updated to 1.07 exponent; Auntie Wave-10 example in CUSTOMER_STATS.md corrected to base HP 135 (~248 HP); FIX-017 entry added to fixes.md recording all stat/scaling corrections.
Test GameState screen initialization
app/src/test/java/com/messark/hawker/StallStatsTest.kt, app/src/test/java/com/messark/hawker/UndeadEnemyTest.kt
currentScreen = AppScreen.GAME added to GameState construction in both StallStatsTest test cases and in UndeadEnemyTest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • candour/towerpower#189: Directly related — both PRs modify the EnemyDefinition.getHp(wave) growth exponent in Registry.kt (that PR set it to 1.05, this PR changes it to 1.07).
  • candour/towerpower#181: Both PRs adjust the same balance constants for StallType.CHICKEN_RICE, StallType.DURIAN, and EnemyType.TIGER_MOM in Registry.kt.
  • candour/towerpower#144: generateEnemyList in that PR uses EnemyDefinition.getHp and Tiger Mom stats from Registry.kt, making wave composition outcomes directly coupled to the exponent and base HP changes here.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main purpose of the PR—synchronizing base stats and enemy HP scaling between code and documentation files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-stats-consistency-1277115244311179560

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@candour candour closed this Jun 26, 2026
@candour
candour deleted the fix-stats-consistency-1277115244311179560 branch June 26, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant