Skip to content

Stats - #185

Closed
candour wants to merge 2 commits into
mainfrom
stats
Closed

Stats#185
candour wants to merge 2 commits into
mainfrom
stats

Conversation

@candour

@candour candour commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Balance Changes
    • Reduced base health values for four enemy unit types
    • Increased Chicken Rice stall damage output
    • Decreased Durian stall damage output
    • Refined stall upgrade scaling progression and rate adjustment mechanics

Your Name added 2 commits June 2, 2026 23:07
@candour
candour enabled auto-merge (squash) June 9, 2026 14:56
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR rebalances gameplay mechanics across three areas: enemy health pools are reduced uniformly by 10%, stall damage outputs are adjusted (Chicken Rice doubled, Durian reduced), and upgrade scaling is simplified and tuned to support the new balance curve through unified damage progression and recalibrated rate-scaler constants.

Changes

Gameplay Balance Tuning

Layer / File(s) Summary
Enemy base HP reductions
app/src/main/java/com/messark/hawker/registry/Registry.kt, CUSTOMER_STATS.md
Salaryman, Tourist, Auntie, and Delivery Rider base HP values are reduced by 10% across the registry and reflected in the customer statistics documentation.
Stall base damage adjustments
app/src/main/java/com/messark/hawker/registry/Registry.kt
Chicken Rice stall damage is doubled from 10f to 20f; Durian stall damage is reduced from 150f to 120f.
Upgrade scaling logic adjustments
app/src/main/java/com/messark/hawker/utils/StallUpgradeManager.kt
DamageScaler removes Chicken Rice special-case additive logic and applies unified multiplicative scaling (1.15×) across all stall types. RateScaler constants are updated to lower Chicken Rice floor and adjust rate reduction values for Chicken Rice, Durian, and Satay.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • candour/towerpower#181: Modifies the same app/src/main/java/com/messark/hawker/registry/Registry.kt balance constants for stall damage and enemy base HP values.
  • candour/towerpower#162: Adjusts StallUpgradeManager.kt DamageScaler and RateScaler progression constants and refactors Chicken Rice special-case logic.
  • candour/towerpower#108: Rebalances enemy stats and stall combat values in Registry.kt for units like Salaryman, Auntie, and Delivery Rider.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Stats' is vague and generic, failing to convey the specific nature of the balance changes (HP reductions, damage adjustments, and scaler updates across multiple systems). Use a more descriptive title that captures the main changes, such as 'Balance adjustments: reduce enemy HP and update stall damage scaling' or 'Rebalance enemy base HP and damage values'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stats
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch stats

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@candour candour closed this Jun 9, 2026
auto-merge was automatically disabled June 9, 2026 14:57

Pull request was closed

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@candour
candour deleted the stats branch June 26, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant