Durian AoE Damage and Visual Falloff - #178
Conversation
- Added `radius` and `sourceStallType` to `VisualEffect` data class. - Implemented linear damage falloff (100% at center to 25% at edge) for Durian stall in `MainViewModel.kt`. - Updated `GameBoard.kt` to render Durian AoE with a radial gradient and isometric scaling matching its actual radius. Co-authored-by: candour <4670475+candour@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds AoE metadata to VisualEffect, records per-hit distances during projectile impacts, applies a Durian-specific distance-based AoE damage falloff, and renders Durian EXPANDING_CIRCLE effects with a radial-gradient oval. ChangesDurian AoE Damage and Rendering
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: baa83728-ba77-4a74-9eb0-ab36751ed5d7
📒 Files selected for processing (3)
app/src/main/java/com/messark/hawker/MainViewModel.ktapp/src/main/java/com/messark/hawker/model/GameModels.ktapp/src/main/java/com/messark/hawker/ui/components/GameBoard.kt
|
Lines 334-352 scale only the draw bounds, not the gradient space. That means the left/right edge reaches the intended 25% falloff, but the top/bottom edge does not, so the visual no longer mirrors the damage curve or the actual isometric radius. Use the board’s Y scale in the radius calculation and scale the shader/canvas itself, not just the oval bounds. |
Good catch! I've updated the rendering logic to scale the canvas vertically based on the isometric Y factor before drawing the circle. This ensures the |
- Updated Durian AoE rendering to use a matrix-scaled `RadialGradient` that mirrors the isometric perspective. - Ensured damage falloff matches the refined visual curve. - Addressed PR feedback regarding visual alignment with the damage curve. Co-authored-by: candour <4670475+candour@users.noreply.github.com>
Build Successful! 🚀Note: This link will be removed when the PR is closed. |
The Durian stand now features a more realistic AoE effect. Damage at the center of the impact is 100% and scales down linearly to 25% at the edge of the explosion radius. Visually, the expanding circle for the Durian explosion now uses a radial gradient that mirrors this decay and its size accurately reflects the stall's upgraded AoE radius.
PR created automatically by Jules for task 13351916444807328427 started by @candour
Summary by CodeRabbit
New Features
Visual Improvements