Skip to content

Improve StallConsole UI labeling and cleanup - #169

Merged
candour merged 1 commit into
mainfrom
fix-stall-console-ui-stats-16907269535054333605
May 23, 2026
Merged

Improve StallConsole UI labeling and cleanup#169
candour merged 1 commit into
mainfrom
fix-stall-console-ui-stats-16907269535054333605

Conversation

@candour

@candour candour commented May 21, 2026

Copy link
Copy Markdown
Owner

This change improves the StallConsole UI by addressing several small bugs and inconsistencies:

  1. Bak Kut Teh stalls no longer show a redundant "Rate: 0.0s" line, as they do not fire projectiles. Their "Range" stat is now labeled "Boost Range" to reflect their function as a buff provider.
  2. Tray Return Uncle stalls now consistently use the label "Grab Rate" for their cooldown, matching the upgrade category and game mechanics.
  3. Cleaned up code by removing the unused hungerValue local variable.
  4. Updated fixes.md with a record of these changes as FIX-015.

PR created automatically by Jules for task 16907269535054333605 started by @candour

Summary by CodeRabbit

  • Bug Fixes
    • Fixed stall stat display to use correctly scaled values for duration, damage, and grab rate calculations.
    • Improved UI clarity by conditionally hiding redundant "Rate" labels for specific stall types.
    • Renamed "Range" label to "Boost Range" for enhanced clarity.
    • Ensured consistent "Grab Rate" labeling across stall types.

Review Change Stack

- Hide "Rate" stat for Bak Kut Teh stalls (always 0 and misleading)
- Rename "Range" to "Boost Range" for Bak Kut Teh for better clarity
- Use "Grab Rate" consistently for Tray Return Uncle stalls
- Remove unused 'hungerValue' variable
- Update fixes.md with FIX-015

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated stall console UI stat display to compute values using scaled multipliers (rateMultiplier, damageMultiplier) instead of raw values, refactored Range stat emission via rangeLabel, and conditionally show Rate/Grab Rate only for non-BAK_KUT_TEH stalls with rate derived from fireRateMs scaled by rateMultiplier.

Changes

Stall Stats Display Update

Layer / File(s) Summary
Scaled Stats Display and Conditional Rendering
app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt, fixes.md
Hunger display value now applies rateMultiplier (duration/freeze) and damageMultiplier (damage) with updated formatting. Range stat is now emitted via rangeLabel-driven path. Rate/Grab Rate stat is conditionally shown only when stall type is not BAK_KUT_TEH, with display rate computed from fireRateMs scaled by rateMultiplier. Changelog entry documents UI labeling changes and removal of unused hungerValue code.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • candour/towerpower#150: Overlapping updates to StallConsole stats display that introduce scaled multiplier-driven rendering.
  • candour/towerpower#159: Shared Bak Kut Teh-specific stat display logic with conditional Rate/Grab Rate rendering based on stall type.
  • candour/towerpower#89: Prior StallConsole.kt refactoring of Rate label conditionals and stat rendering for specific stall types like Tray Return Uncle.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Improve StallConsole UI labeling and cleanup' directly addresses the main changes: UI label improvements (renaming Range to Boost Range, Grab Rate consistency) and code cleanup (removing unused hungerValue).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-stall-console-ui-stats-16907269535054333605

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a9c20fd1-3bbd-47e1-b81b-248ee7bb4369

📥 Commits

Reviewing files that changed from the base of the PR and between 5ccf6eb and 02b27b1.

📒 Files selected for processing (2)
  • app/src/main/java/com/messark/hawker/ui/components/StallConsole.kt
  • fixes.md

Comment thread fixes.md
@github-actions

Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@candour
candour enabled auto-merge (squash) May 23, 2026 11:30
@candour
candour merged commit 6fb369d into main May 23, 2026
3 checks passed
@candour
candour deleted the fix-stall-console-ui-stats-16907269535054333605 branch May 23, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant