Repository navigation
feat: label the re-enable PR and the Hub spec-bump PR and issue with hub - #734
Merged
Merged
Conversation
The automation PRs and issues already carry hub except these. The spec-bump check also runs for camunda-oca, so the label is added for the Hub config only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3526HsTZMmihMi94p34Pr
|
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused labeling changes are correctly scoped, best-effort where required, and covered by regression tests.
0 open findings
What changed in this PR
Adds consistent hub labeling to Hub automation artifacts while keeping OCA spec-bump artifacts unchanged.
Changes:
- Adds a config-aware spec-bump label helper.
- Labels Hub spec-bump PRs, tracking issues, and re-enable PRs.
- Adds regression tests covering both configurations and affected scripts.
| File | Description |
|---|---|
.github/scripts/spec-bump-common.sh |
Adds the config-specific label helper. |
.github/scripts/spec-bump-open-pr.sh |
Labels new and existing Hub bump PRs. |
.github/scripts/spec-bump-report.sh |
Labels new and existing Hub tracking issues. |
.github/scripts/hub-reenable-check.sh |
Labels re-enable PRs as Hub-related. |
tests/request-validation/hub-label-automation.test.ts |
Tests label selection and script integration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every PR and issue the Hub automation opens carries the
hublabel, except three. This adds it to them:hub-reenable-check.sh): it carried onlynightly-api-fix.spec-bump-open-pr.sh), when it opens and when it finds one already open.spec-bump-report.sh), when it opens and on every update.How
camunda-oca, so a newconfig_labelhelper inspec-bump-common.shreturnshubforcamunda-hubonly and nothing for any other config.edit, not--labelon create, so a label that failed to create can never lose the PR or issue itself (the same pattern the issue script already uses formissing-coverage).--label nightly-api-fix --label hub, like the label it already pre-creates.Notes
tests/request-validation/hub-label-automation.test.ts(4 tests) runs the realconfig_labelhelper for both configs and checks that each script adds the label where intended. It passes, with Biome andtscclean.hublabel already exists in the repo; the scripts still try to create it best-effort.hubto generator PRs (see docs: one-page how-it-works guide for the Hub team, and trim the Hub guides #711).🤖 Generated with Claude Code
https://claude.ai/code/session_01G3526HsTZMmihMi94p34Pr
Generated by Claude Code