Skip to content

QoS B&A - fix warnings reported against snapshot r2.2 - #157

Merged
Masa8106 merged 5 commits into
camaraproject:mainfrom
gmuratk:gmuratk-fix-warnings-snapshot-r2dot2
Oct 20, 2026
Merged

Masa8106 merged 5 commits into
camaraproject:mainfrom
gmuratk:gmuratk-fix-warnings-snapshot-r2dot2

Conversation

@gmuratk

@gmuratk gmuratk commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • bug

What this PR does / why we need it:

To address the validation warnings reported during snapshot r2.2 validation

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

@Masa8106 - I reviewed the report generated for the snapshot and this PR should address the warnings reported for QoS B&A.

Changelog input

 release-note

- API spec: replaced the `identifying-device-from-access-token` section of `info.description` with the canonical Commonalities template (the API-specific 3-legged token guidance remains in its own section).
- API spec: removed the unused `BOOKING_CANCELLED` example from `components/examples`.
- API spec: added a `pattern` (`^[A-Z][A-Z0-9_]*$`) to the `BookingStatusInfo` schema.
- Test definitions: restructured the scenarios that follow up on a prior operation so each has a single When/Then (Given/When/Then order):
  - `createBooking`: created booking can be read with `getBookingById`
  - `deleteBooking`: deleted booking can no longer be read
  - `assignDevices`: assigned devices are returned by `getDevicesByBookingId`
  - `releaseDevices`: released devices are no longer returned by `getDevicesByBookingId`

Additional documentation

This section can be blank.

docs

Refactor the getBookingById scenario to streamline the process of verifying the created booking details.
Updated scenario for released devices to include booking ID parameter and removed redundant request.

@Masa8106 Masa8106 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmuratk, sorry for my late response, however, thank you for creating this PR.
LGTM. I will re-create a snapshot.

@Masa8106
Masa8106 merged commit 78e52c4 into camaraproject:main Oct 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants