Release Review: OTPValidation r4.2 (rc Sync26) - #167
Open
camara-release-automation[bot] wants to merge 2 commits into
Open
camara-release-automation[bot] wants to merge 2 commits into
camara-release-automation[bot] wants to merge 2 commits into
Conversation
camara-release-automation
Bot
requested review from
bigludo7 and
fernandopradocabrillo
as code owners
October 1, 2026 16:50
6 tasks done
CAMARA Validation — PASS0 errors, 0 warnings, 1 hints | Profile: standard |
Updated changelog to reflect recent changes including renaming a class, refactoring error response references, and removing redundant documentation.
hdamker
reviewed
Oct 2, 2026
hdamker
left a comment
Contributor
There was a problem hiding this comment.
Release Management review of r4.2 (one-time-password-sms 2.0.0-rc.2).
Content: no findings.
- No wire-contract change against 2.0.0-rc.1:
oasdiff changelogreports nothing. The 400/401/403 responses are now byte-identical to the Commonalities r4.4 catalogue entries, all examples match the sharedGENERIC_*examples, and the localOneTimePasswordSMS429keeps both 429 codes as #165 offered in its alternative solution. "Breaking changes: N/A" is correct. - CAMARA Validation: 0 errors, 0 warnings, 1 hint. The S-313 hint is on
Code, which has no fixed format because the OTP format depends on the implementation, so it needs no deferral issue. - Mandatory assets for rc are all present. Test definitions are updated to
v2rc2, and #152 / #165 under #151 are both closed.
CHANGELOG: one fix before merge (see the inline suggestion)
- The two Changed entries describe internal component renames. A consumer reading them can't tell that the responses stayed the same. Following the r4.1 precedent ("Aligned ... to Commonalities r4.3"), the suggestion combines them into one r4.4 alignment entry that states the wire contract is unchanged.
After the CHANGELOG is updated, this is ready to approve from the Release Management side.
Comment on lines
+71
to
+72
| * Rename 429 class to avoid 'generic' use from common file by @bigludo7 in https://github.com/camaraproject/OTPValidation/pull/166 | ||
| * Refactor error response references in OTP SMS API (comm. r4.4) by @bigludo7 in https://github.com/camaraproject/OTPValidation/pull/159 |
Contributor
There was a problem hiding this comment.
Suggested change
| * Rename 429 class to avoid 'generic' use from common file by @bigludo7 in https://github.com/camaraproject/OTPValidation/pull/166 | |
| * Refactor error response references in OTP SMS API (comm. r4.4) by @bigludo7 in https://github.com/camaraproject/OTPValidation/pull/159 | |
| * Aligned error responses to Commonalities r4.4 (0.9.0). Response codes, error codes and response schemas are unchanged. | |
| * 400/401/403 now use the Commonalities r4.4 catalogue responses (`BadRequest400`, `Unauthenticated401`, `PermissionDenied403`) with shared examples, by @bigludo7 in https://github.com/camaraproject/OTPValidation/pull/159 | |
| * 429 is defined locally as `OneTimePasswordSMS429` instead of the deprecated `Generic429`, keeping `QUOTA_EXCEEDED` and `TOO_MANY_REQUESTS`, by @bigludo7 in https://github.com/camaraproject/OTPValidation/pull/166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Review: r4.2 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
2.0.0-rc.22.0.0-rc.1Dependencies: Commonalities r4.4, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
mainPR are collected as sub-issues of one issue titledRelease r4.2 review findings(see Recording review findings)Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r4.2-da68f85