Fix152&165

[bigludo7]

What type of PR is this?

Add one of the following kinds:

• cleanup

What this PR does / why we need it:

• Remove redundant documentation/API_documentation/OTP_SMS_API.md document
• rename 429 class to avoid 'generic' use

Which issue(s) this PR fixes:

Fixes #152, fixes #165

Special notes for reviewers:

Changelog input

 release-note
- Remove redundant documentation in the md document
- rename 429 class to avoid 'generic' use

Additional documentation

This section can be blank.

docs

[camara-validation]

CAMARA Validation — PASS

0 errors, 0 warnings, 1 hints | Profile: standard

View full results

[hdamker]

There is not much left of documentation/API_documentation/OTP_SMS_API.md ... any reason to keep these few lines? Or would it be enough to mention in CHANGELOG that the obsolete file was removed, and the documentation is now in the YAML?

[hdamker]

Additional comments after a closer look:

• Local 429 examples: per the r4.4 Design Guide response template, the examples of OneTimePasswordSMS429 can reference the shared ones (../common/CAMARA_common.yaml#/components/examples/GENERIC_429_QUOTA_EXCEEDED and GENERIC_429_TOO_MANY_REQUESTS) instead of inline copies. Not blocking.
• OTP_SMS_API.md: the endpoint list now hardcodes /v2/ while main is vwip, the same kind of drift reported in OTP_SMS_API.md documentation out of sync with API definition #152. If the file is kept, dropping the versioned endpoint list avoids this. I would still recommend to drop the file completely.
• Issue linking: Fixes #152 #165 only links the first issue. Please use Fixes #152, fixes #165 so both close on merge. In general it would be better to do the fixes in two PRs with concrete PR titles, which makes the CHANGELOG generation easier.

[bigludo7]

@hdamker Yes I was also thinking that this documentation/API_documentation/OTP_SMS_API.md is useless. I remove it !

[bigludo7]

@hdamker all fixed :)

[fernandopradocabrillo]

LGTM
Thanks @bigludo7