fix(device-swap): correct /retrieve-date 400 and stale metadata - #122
Merged
bigludo7 merged 1 commit intoSep 18, 2026
Merged
Conversation
hdamker
requested review from
bigludo7,
jgarciahospital and
krishvenkatachalam
as code owners
September 18, 2026 10:21
/retrieve-date's request body has no ranged field, so BadRequestWithRange400's OUT_OF_RANGE regressed camaraproject#106/camaraproject#109 by documenting an uncallable error code; switch to BadRequest400. Also drop the now-empty components.responses key left by the r4.4 ref consolidation, and bump x-camara-commonalities to the r4.4 value already adopted by that consolidation.
hdamker
force-pushed
the
fix/retrieve-date-400-and-cleanup
branch
from
September 18, 2026 10:25
ac8c713 to
c9338ab
Compare
4 of 9 tasks
bigludo7
approved these changes
Sep 18, 2026
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fixes the two regressions and the stale field found in #121:
/retrieve-date's400pointed atBadRequestWithRange400, which documentsOUT_OF_RANGE— but the operation's request body has no ranged field, so that code can never occur. This undid the narrowing from 400/404 document error codes that can't occur; 403 and strictness are untested #106, which /check 400 response over-narrowed: OUT_OF_RANGE removed but still reachable via maxAge #109 explicitly asked to keep. Switched toBadRequest400(INVALID_ARGUMENTonly)./checkkeepsBadRequestWithRange400— it has a ranged field (maxAge) and both codes are tested.components.responses:key left over after the r4.4 ref consolidation moved all local responses to$refs.info.x-camara-commonalitiesfrom0.6to0.9.0to match the r4.4 catalogue the API already consumes.Which issue(s) this PR fixes:
Fixes #121
Special notes for reviewers:
Local validation (
camara-validate-local): pass, 0 errors/0 warnings/0 hints.Changelog input
Additional documentation
This section can be blank.