Skip to content

[Added / Changed / Removed] Updates for Commonalities r4.4 - #102

Open
eric-murray wants to merge 13 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-3
Open

eric-murray wants to merge 13 commits into
camaraproject:mainfrom
eric-murray:eric-murray-patch-3

Conversation

@eric-murray

@eric-murray eric-murray commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Make additional changes now that common files are imported from Commonalities r4.4

  • Update error response schema to use new common schema or locally defined schema
    • Remove 403 INVALID_TOKEN_CONTEXT and 404 NOT_FOUND from device-roaming-status
    • Add 422 MULTIEVENT_COMBINATION_TEMPORARILY_NOT_SUPPORTED and PRIVATE_KEY_JWT_NOT_CONFIGURED for device-roaming-status-subscriptions subscription creation
  • Add new test scenarios
    • @roaming_status_subscriptions_09_subscription_creation_initial_event
    • @roaming_status_subscriptions_10_Create_roaming_status_subscription_sync_with_accesstoken_sink_credential
    • @roaming_status_subscriptions_11_Create_roaming_status_subscription_sync_with_private_jwt_key_sink_credential_out_of_band_provisioning
    • @roaming_status_subscriptions_12_Create_roaming_status_subscription_sync_with_private_jwt_key_sink_credential_in_band_provisioning
    • @roaming_status_subscriptions_422.02_creation_with_private_jwt_key_not_configured
    • @roaming_status_subscriptions_03_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_access_token_sink_credential_returned
    • @roaming_status_subscriptions_04_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_private_jwt_key_sink_credential_returned
    • @device_roaming_status_429.01_Too_Many_Requests
    • @device_roaming_status_429.02_Quota_Exceeded

Which issue(s) this PR fixes:

Fixes #103

Special notes for reviewers:

None

Changelog input

 release-note
 - Updates for Commonalities r4.4

Additional documentation

None

@eric-murray
eric-murray marked this pull request as draft September 14, 2026 16:21
@eric-murray
eric-murray marked this pull request as ready for review September 25, 2026 12:19
@eric-murray eric-murray changed the title Updates for Commonalities r4.4 [Added / Removed] Updates for Commonalities r4.4 Sep 25, 2026
@eric-murray eric-murray changed the title [Added / Removed] Updates for Commonalities r4.4 [Added / Changed / Removed] Updates for Commonalities r4.4 Sep 25, 2026

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review error response schemas following deprecation of "Generic" error response schemas by Commonalities r4.4

2 participants