Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 0 hints | Profile: standard |
maheshc01
force-pushed
the
rc-prep/review-findings
branch
from
September 14, 2026 17:58
107abc1 to
ff18efa
Compare
- Reuse the Rate / RateUnitEnum schemas from QualityOnDemand for the response and rename the property to maxDownstreamMediaRate (#39) - Clarify that the returned value is the maximum rate the network allows for the device, as enforced for media traffic, not a measurement or forecast of achievable throughput (#41) - Point externalDocs.url to this repository (#42) - Declare error responses explicitly with only the codes this API can return; 500 removed, 429 kept (#40) - Consolidate test definitions into a single media-streaming-rate.feature covering happy path, request validation, C01 device errors, 401 and 403 - Update README scope to describe the API purpose
maheshc01
force-pushed
the
rc-prep/review-findings
branch
from
September 14, 2026 17:59
ff18efa to
7a32b69
Compare
Contributor
Author
|
@Kevsy Please review these changes based on the review comments you had shared. I will create a separate PR for yaml and api name changes as its causing failures in automated validations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Prepares the API definition and test definitions for the r1.2 release candidate by resolving the content-related review findings collected in #37 from the r1.1 alpha review:
Rate/RateUnitEnumschemas from QualityOnDemand for the response and renames the property tomaxDownstreamMediaRate.externalDocs.urlto point to this repository.500is removed;429is kept (see Check whether 429 and 500 errors are needed for this API #40).media-streaming-rate.featurecovering happy path, request validation, the Commonalities C01 device error scenarios, 401 and 403.The spec validates cleanly against the CAMARA Spectral r4 ruleset and the feature file against the CAMARA gplint configuration.
Which issue(s) this PR fixes:
Fixes #39
Fixes #41
Fixes #42
Partially addresses #40 (500 removed; 429 will be finalised with the Commonalities r4.4 alignment). Part of #37.
Special notes for reviewers:
device-media-streaming-rate(Repository name does not match API name #38) is deliberately not in this PR. It is in Rename API to device-media-streaming-rate #49, stacked on this branch, so that this PR validates green. The validation rules tie the file name torelease-plan.yamland forbid changing the release plan alongside other files, so the rename and the release-plan update (Release plan: r1.2 release candidate on Commonalities r4.4 #48) cannot both be green while the other is unmerged. Intended order: this PR, then Rename API to device-media-streaming-rate #49, then Release plan: r1.2 release candidate on Commonalities r4.4 #48.code/commonsync for r4.4 has landed.maxDownstreamMediaBitRateSupported+unittomaxDownstreamMediaRate(Rateobject) is a breaking change relative to 0.1.0-alpha.1, which is acceptable for a 0.x API moving to rc.Changelog input
Additional documentation