Repository navigation
Feature/default recipe authoring - #160
Open
matthewpeterkort wants to merge 30 commits into
Open
matthewpeterkort wants to merge 30 commits into
matthewpeterkort wants to merge 30 commits into
Conversation
Validate multipart upload, retry and receipt handling with the standalone client race suite. Keep the client module independent of the Loom server.
Replace the dataset-wide multipart request and graph transaction with one validated multipart upload per ResourceType file, durable receipts, bounded candidate-generation writes, and a final verified recipe/release activation. Preserve unselected files, replace selected contents including deletions, and rebase copied references into the candidate generation. Keep the source Git commit distinct from operation-specific generations. Expose safe row validation details through HTTP, the standalone client, and worker logs. Maintain generated streaming handlers through a pinned template. Handle lost file and activation acknowledgements without discarding accepted data or creating a second release revision. Document staging retention limits. Validation: full Go suite on Go 1.26.5; standalone client and ETL suites; real fasthttp streaming/limit/truncation probes; isolated Arango validation, multi-batch copy, deletion, lost file ACK, and lost activation ACK regressions; OpenAPI generation byte-identical, route ownership and error-response audits. Review: separate API, SDK, backend-state and authorization reviews. Reproduced and repaired eager buffering, rejected-part draining, truncated 422 retries, mutated pagination cursors, and initial activation acknowledgement recovery.
Remove the source-load handler rewrite that changed HTAN_INT-BForePC into HTAN_INT/BForePC before storage. Keep the supplied project ID consistent with scoped catalog lookup. The handler and real scope-resolver regression failed before the fix with an empty restricted scope and passes afterward. Load, authorization and server package tests pass; separate authorization review found no bypass.
Repair fresh-database source publication failing authorization before ingestion can initialize its schema. Verified authscope, bulk/load, and server suites plus compiled startup against a disposable fresh Arango database. Narrow startup diff received independent same-model review with no verified findings.
Consume streamed HTTP framing before reusing multipart upload connections, latch EOF, and close rejected streams without draining. Keep generated GroupMember row identities nonnullable for ClickHouse sorting keys while preserving optional field nullability. Regression checks reproduced next-request HTTP400 and nullable identity before the fixes; final focused and repository Go suites plus OpenAPI checks pass. Independent same-model review verified the EOF edge repair, early rejection, and schema propagation.
Resolve the missing default Explorer from the configured recipe's exact active release, published execution and immutable recipe version. Preserve authored Explorers, conceal unauthorized or stale outputs, and filter internal metadata. Verify full execution scope coverage and optional no-auth wiring. Focused regressions, full Go suite, three independent same-model reviews and a real published dataset read-only projection check pass; the resulting wire response passes the frontend validator.
Save independent named presentations against one compiled recipe execution, and activate config revisions with the data release in one transaction. Load chart-supplied definitions at startup and serve saved Viewer state through the ordinary read path. Validation: complete Go package coverage and repository gates, script checks, three disposable Arango publication tests, and real BForePC config attachment/replay with unchanged data release. Three independent gpt-6.1-sol reviews resolved their reproduced findings. Tested source tree: ff91fb7.
Regenerate the embedded OpenAPI blob with the pinned Go 1.26.5 toolchain. The decompressed specification and all other generated code are byte-identical; the compressed output now exactly matches CI. Use the CI Arango endpoint variable for project-config tests and require all three cases in the integration profile. Validation: generated API/server suites, three real Arango cases, runner unit tests, OpenAPI ownership checks, repeated generation, inventory checks, and independent CI-wiring review.
Update the two shifted source line references while preserving their expected predicates and every stale-publication assertion. The full Explorer Arango CI profile passes against disposable databases, including the new project-config cases and cleanup; independent review confirmed this changes no guard or tolerance.
Add a standalone presentation API for published dataframe tables, per-project view defaults, immutable catalog anchors, and optimistic view saves. Preserve saved definitions and defaults during source publication; unavailable filters make affected tabs fail closed until repaired. Remove the global startup view catalog while retaining the configured dataframer recipe. Validation: all 68 Go packages pass; disposable Arango covers view save, defaults, deletion, publication rebind, A-B-A restoration and exact retries. Independent Sol reviewers reproduced and verified fixes for scoped-editor capabilities, revision restoration and snapshot detachment. Generated OpenAPI route ownership, HTTP error audit and source UI inventory checks pass.
Preserve the existing graphical builder, import configured recipes into native authoring, and support project-owned drafts plus explicit shared-default editing. Restore imported Filter and Calculate previews while preserving dynamic-field drift validation. Reduce FHIR field-lookup allocation and improve builder operation controls and empty states. Validation: affected Go schema, lifecycle, compilation, server and execution suites; ownership/race checks; affected UI tests and type checks; authenticated BForePC browser and live Filter/Calculate preview checks. Imported-source recoding and source graph mutations remain limited; preview latency remains follow-up work.
Restore the persistent dataframe tracker and expose the configured recipe's source operations before authored transformations. Save bounded source edits in project drafts, re-resolve schemas, and reject broken downstream inputs. Keep shared recipe pins immutable and existing drafts reloadable. Task: restore and fix the dataframe step tracker for the default recipe. Validation: full authoring/importer/compiler/lifecycle suites; focused server and HTTP transport checks; 177 UI tests; typecheck, boundaries and UI build; isolated native Chrome editing/retry/reload and desktop/mobile acceptance. Same-model three-seat review closed after fixing required enablement decoding and deep-route step IDs. Deployed authenticated acceptance was not run. Reviewed/tested source identity: 10296374d8b67695a8cb1282a82659fc31464bc51fb68793a9e97ad48e4675a5
Send semantics version 11, matching the Go command decoder. Replace the UI test's hardcoded old version with a check of the actual Go declaration so focused frontend checks catch future drift. Repair: live Builder rejected commands with UNSUPPORTED_SEMANTICS_VERSION. Validation: 141 API/types tests, existing Node cross-version guard, UI build, and authenticated local doctor/browser load with the matching backend image. Three same-model focused reviews closed; old version 10 fails the new guard.
Collapse consecutive source projections within their original scope and order. Keep traversals and row-changing operations as boundaries, and expose one source inspector instead of descriptions and settings on every card. Collapse contiguous construction column adjustments; keep Expand outside column-only groups. Keep selected Group keys and contributor values visible while their searchable catalogs open on demand. Flatten the editor hierarchy, compact row-intent controls, and distinguish saved from proposed previews. Size the desktop table viewport below the embedding navigation without changing operation or backend contracts. Task: compact dataframe step tracker and Group editor presentation. Validation: 103 Group tests, 32 tracker tests, 49 row-intent host tests, 100 reconciliation/preview tests; UI build/typecheck and boundary checks. Three same-model focused adversarial reviews; source identity and verification receipt retained in .artifacts/compact-builder. Native viewport/resize proof passed before label-only changes; durable source edit/reload/restore and complete Group browser acceptance remain pending. Operator requested this snapshot commit now before preparing the graph/row-definition work package.
Add a dedicated work package and seven dependency-ordered implementation briefs for native relationship authoring, explicit row identity and effects, the main editor, connected values and operations, persistence, and native acceptance. Include the exact default Helm recipe and link the tickets into the active queue. Ground the plan in current code: imported source overlays retain their pin, Document.route is a separate ordinary-document contract, and source rows differ from construction-stage grain. Require typed native additions, stable occurrence mapping, explicit stage anchors and supported row operations. Validation: local links, seven unique tickets, acyclic dependencies, matching queue statuses, unchanged existing queue bytes, and exact reference recipe hash. Frontend and backend source reviews informed the final ticket boundaries. Carry forward incomplete native acceptance from presentation commit 4b64797.
Implement GRAPH-ROWS-01 through GRAPH-ROWS-07 contracts, typed project-local recipe overlays, row identities, main editor integration, persistence, and independent fixtures. Preserve immutable recipe pins and receipt-bound ownership. Validation: 193 draft tests, 17 real-Arango cases, compiler and execution suites, UI build/typechecks, and exact-source same-model reviews. Functional verification gaps and authenticated infrastructure limitations are recorded in the work package. Operator authorized pushing with verification pending; five-second timing is advisory.
Task: refine the remaining Loom Builder work into a source-grounded gap analysis and GRAPH-ROWS-08 through GRAPH-ROWS-11. Define shared edit ownership, an editable row expression, authored traversal editing, and the composed Calypr workspace. Extend 06/07 with cross-interface persistence and native acceptance requirements. Validation: Astra reviewed the ticket scope and its amendments; local Markdown links, TSV shape, unique ticket IDs, acyclic dependencies, and staged whitespace checks pass. Preserve prior scoped implementation evidence; no new product acceptance is claimed.
Complete the GRAPH-ROWS backend candidate/policy contract unit: derive source, row and root candidate documents, networks and row identities from verified receipts; add closed ordinary column-policy Preview/Apply with stable targets, authorization and draft CAS; preserve imported pins and legacy identity gaps. Keep related FIRST/ALL contributors in original logical-record order through compact/projected sets. Advance compiler contract to v20; v19 remains readable but cannot execute or share the current compilation cache. Verification: full authoringv2/lifecycle; affected compiler, explorer and execution packages; four public HTTP contracts; real Arango legacy fixture and six generation/order/duplicate/array/metadata cases, independently repeated. Exact-source same-model reviews include order manifest 75b465357f4df552, column policy 72cd05450ef3266c and root candidate final manifest. The 38-path review coverage audit is c49bea7751efc42c62b6bd08e3fd76ba0ec188545d93b3e41e20dc3b63241be4. See VERIFICATION.md for commands, raw evidence, scopes and remaining native and authenticated acceptance. This commit does not complete those acceptance tasks.
Complete the mixed scalar compiler repair unit. RELATED_FIELD and RELATED_SOURCE rebuilt their stage outputs without the hidden dynamic-key inventory, causing valid full-default recipe previews to fail before any save. Carry the existing inventory through both row-preserving operations without exposing it publicly or relaxing frozen-key/type validation. Advance the executable compiler contract to v21. Generic v20 artifacts remain readable for inspection, but cannot execute or share current cache entries; historical proposal bindings retain their current-only contract guards. Validation: all affected compiler, execution, explorer, authoring, recipe-import and lifecycle packages passed. Six real-Arango full-default cases independently repeat exact pairs/lists/scalars, unknown-key/type rejection and metadata privacy. A native no-Apply scalar preview and an independent public request replay return six exact rows with all prior values and saved state preserved. Exact-source same-model review: manifest 6db91363bdae7fb0e886ca24b075f7d37d54a72167e6c6f2d9cb9514253a4ab8. VERIFICATION.md records the actual failures, commands and scoped evidence. Full final native matrix and authenticated Calypr acceptance remain separate.
Implement the complementary GRAPH-ROWS editors around one typed recipe-editing owner. Bind existing terms to their occurrence, column, operation and input stage; show authored traversal separately from catalog possibilities; share saved or receipt-bound proposed results, one inspector, Apply, Cancel and stale recovery. Preserve source list policies during explicit related-row expansion, expose a separate per-match scalar, display complete Group keys and contributor policies, and keep history ordered and bounded. Restore keyboard focus after late portal commits without stealing focus after navigation or a newer edit. Keep closed catalogs inactive and source-row choosers closed after operation handoff. Normalize empty construction steps to their existing canonical wire shape so valid source proposals apply after the last operation is removed. Keep strict workspace integrity, draft CAS, authorization and immutable pin boundaries. Validation and exact-source same-model review receipts are recorded in VERIFICATION.md. Final authenticated Calypr acceptance remains separately blocked by unavailable E2E credentials; owned fixture evidence does not replace it.
Implement independent exact-value oracles and twelve registered native workflows for graph-first, row-first, mixed, related rows, Group, source steps, ordinary policies, root changes, dependency rejection, concurrent drafts and bounded history. Retain immutable source/binary/config identity checks and zero retries. Record eleven passing whole owned-fixture cases, strict graph/row canonical equivalence, focused checks, builds and exact-source same-model reviews. Preserve the fresh history setup failure at the 99th proposal after 98 saved operations; no native history phase ran. Authenticated Calypr remains separately blocked by missing E2E credentials. Neither incomplete requirement is represented as done. See docs/work-packages/record-network-and-rows/VERIFICATION.md for exact source identities, commands, raw evidence and ticket status.
Reuse a compilation key only after it has been computed and verified in the same Validate call. Keep public ReceiptID and ValidateID fresh. Replace discarded raw JSON re-encoding with syntax validation, retaining the original decoder fallback for exact invalid-input errors. Preserve all content addresses, compiler contracts, corruption checks, authorization and draft CAS boundaries. Profiled the actual owned API request before changing the implementation. The captured 99-operation receipt benchmark allocates about 37% less memory; independent parent measurements confirm the allocation reduction while retaining noisy timing samples. Exact-old-function differential review covers identity/error equivalence, legacy formats, malformed JSON, numeric forms and caller mutation. Focused and full affected Go checks pass. Final native evidence and authenticated acceptance limitations are recorded in the work-package verification record. Exact-source same-model review: manifest 35ecb7abc3ea5488b98dc053565ee8c24591906562cd8773a4bdc6ed5813544a; receipt work/review-candidate/receipt-local-reuse/receipt.md in the isolated review checkout. Full go test coverage: internal/explorer, explorer/arango, explorer/compilation and explorer/lifecycle. Final owned native source134faf8b passed all12 cases/105 actions; authenticated Calypr still needs its E2E token.
Bound the shared mutation inspector so long operation forms and proposal details scroll independently while Apply and Cancel remain visible at desktop sizes. Preserve every field, callback, proposal owner and operation. Select the actual proposed-preview scroller in the history check while retaining all geometry gates. Complete the owned GRAPH-ROWS follow-up matrix: 12 whole native workflows and 105 actions on source134faf8b, with strict graph-first/row-first canonical semantics, independent exact rows/values, source-step and Group persistence, real two-browser stale recovery, and 100-operation layouts at900/1100/back. Retain original fixture creation versus current-source admission provenance, failed attempts, the reviewed storage isolation and exact-source review scopes. Validation: 39 focused UI tests, package and demo production builds, 10 history helper checks, independent source/geometry review and final native matrix pass. Exact UI review8f4df334, collector62a24267, 57-path audit9dd78646 and final 13-document review are traceable in the verification record. Source code and reviewed artifacts retain their tested hashes through commit creation. Authenticated Calypr authoring journeys and the267-column host frame remain incomplete because the E2E token is unavailable. Tickets remain verification-in- progress for that scope; owned fixture tests do not replace it. No production changes or deployment are authorized by this commit.
Local Calypr update repair: Next resolves .tsx before .ts on case-insensitive filesystems, so the rowRecipeExpression helper import selected RowRecipeExpression.tsx. Rename the unchanged helper to rowRecipeProjection and update its four callers. Validation: reproduced Next extension resolution and casing warning; corrected module resolves distinctly; 16 focused row expression/projection/policy tests pass; production TypeScript check passes; Calypr landing and Builder routes return 200; rendered landing page has no page errors; emitted Builder chunk includes the new projection helper and both new editors. Authenticated Builder lifecycle not run.
Add typed project-local source parameters, stable field/generated-column identities, scoped traversal navigation, a shared contextual inspector and proposal preview, and independent default-recipe fixtures/native verification entry points. Operator explicitly requested pushing the current checkpoint before remaining acceptance completes. Preserve immutable pins and existing compiler boundaries. Validation: focused backend packages and source-edit checks passed; full UI library/demo build and 53 final affected UI tests passed; 79 native oracle/guard tests passed. Exact-source independent same-model reviews and confirmed repair reproducers passed (pstack skill unavailable, not claimed invoked). Native OUTPUT lifecycle passed at source fingerprint 8d5b2e5cbd56cc45ab2dddc11a89820c7b15f9849c55f96fd2b8bb53997c5b0d. Known incomplete checks: FIELD_GROUP locator ambiguity, intermittent default history Preview timeouts after 4/33 operations, remaining native lifecycle/A-B checks, and authenticated Calypr acceptance without credentials. See TRAVERSAL-FIRST.md for coverage, evidence boundaries and reproduction entry points. No deployment or production changes.
…l-first-workspace
Preserve upstream macOS filename fix 2bd807b when integrating the traversal-first checkpoint. Update the navigator import to the unchanged renamed helper. Package TypeScript no-emit check passes on the merged snapshot; full native acceptance remains incomplete as recorded in TRAVERSAL-FIRST.md.
Local PR160 deployment repair: rename the unchanged traversalScopeNavigator helper to traversalScopeModel so Next extensionless resolution cannot select TraversalScopeNavigator.tsx on a case-insensitive filesystem. Update its two imports. Validation: confirmed installed Next resolves .tsx before .ts; 13 navigator/model tests pass; production TypeScript check passes; helper bytes unchanged; emitted Calypr Builder bundle resolves traversalScopeModel without the erroneous lowercase component path; Builder route and Loom readiness return 200; real Chrome landing page renders without page errors. Authenticated editing acceptance remains unverified.
Repair the Next.js import crash from BuilderWorkspace reading import.meta.env. Add optional host-selected workspaceComposition, forward it to the existing layout default, and read VITE_LOOM_WORKSPACE_COMPOSITION only in the Vite demo. Reject production Vite environment reads in the package boundary check. Validation: 32 focused Builder/workspace tests pass including public loaded-table placement and no-Apply regression; production TypeScript and both package/demo builds pass. Actual Next host renders a fixture-backed selected table with inspector-right and no browser errors. Boundary guard fails on the original source; missing prop-forwarding negative control fails. Three gpt-6.1-sol reviews found no verified issues, including external type consumer, SSR and alternate Vite demo build. Reviewed diff SHA256 e5eeac5d8eec5e8a5b6cb5a04b5dfa7c53584b6130ff8cfd75ec9d648f068b50. Full authenticated dataset editing is outside this regression check.
Replace the duplicated traversal bar and left navigation with a stable occurrence graph and one right-hand recipe editor. Show legal additions as clickable connected ghost nodes, preserve default recipe controls, and keep pan/zoom fixed while inspecting nodes or paging additions. Fix shared-recipe click blockers from the imported notice and inherited pointer-events. Preserve unresolved saved occurrences and route preview connectors around lower sibling and cousin subtrees. Validation: 103 focused tests; TypeScript, library build and boundary checks passed. Native Calypr/Next fixture checks covered geometry, selection/camera stability, keyboard additions, and imported mouse Preview/Apply/reload. Backend responses were simulated; this is not a claim of authenticated backend-write acceptance. The broader suite's 42 previously documented baseline reconciliation failures remain. Three gpt-6.1-sol reviewers covered actions, lifecycle and geometry. Confirmed pointer, test-isolation and connector-crossing findings were reproduced and repaired; no unresolved verified findings in that scope. Reviewed graph SHA256: c9f7d5a41767307327a69b828ee7b2644748a322a529ba10b6f3dc2b59504631 Tested pre-commit patch SHA256: b9cc3e5911d54a2fc0e3542d8012eae5ede8446ea3e15cf71badb2ed56b7557f Local evidence: .artifacts/one-panel-editor/connected-neighbors-receipt.json (disposable evidence intentionally excluded from this commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.