Say "Dry Run" in the workflow_dispatch checkbox label - #54
Merged
Conversation
GitHub renders only the input description as the checkbox label, so the previous wording -- "Report what would happen without uploading or invalidating" -- never showed the term a developer would scan for. The run-name already said "(dry run)", so the run title and the control that sets it disagreed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkbox that controls the dry run never said "dry run":
GitHub renders only the description as the label for a boolean
workflow_dispatchinput, so the term a developer would scan for appearednowhere on the page. The
run-nameexpression already rendered "(dry run)" inthe run title, so the title and the control that sets it disagreed.
Pairs with caltechlibrary/workflows#6, which fixes the same wording on the
shared action.